Opened 14 years ago

Closed 14 years ago

Last modified 12 years ago

#646 closed defect (fixed)

Widget-destruction-process calls selectTab

Reported by: js-dojo-tester Owned by: mumme
Priority: high Milestone:
Component: Widgets Version: 0.2
Keywords: Cc:
Blocked By: Blocking:

Description

In TabContainer?.js the removeChild-method sometimes calls this.selectTab(this.children[0]). This operation is OK and as expected because if we close a certain tab inside a tabcontainer one of the previous/other tabs should automatically be selected.
However if the tabcontainer itself is part of another widget and this widget is destroyed (e.g. a tabcontainer inside a tab of another tabcontainer and the master-tab is closed) than during the destruction-process the tabcontainer's removeChild is called and also the corresponding selectTab(previous-tab).
If for instance the destroyed tab contained a linkpane with 'preload' set to false, during the destruction-process of the tabcontainer the remote content will be fetched (because of the selectTab-call). If this remote content contains javascript and 'executeScripts' is set to true this can/will cause all sorts of errors.

Detected on kitchen-sink-build-2006-04-23.

Change History (3)

comment:1 Changed 14 years ago by (none)

Owner: changed from anonymous to mumme

comment:2 Changed 14 years ago by mumme@…

Resolution: fixed
Status: newclosed

Ok if understood you correctly this is taken care of in rev3798. changes: dont refresh when onClose and on postCreate (setting default selected).

However the executescripts mess is allways going to be up to the script author to make sure it doesnt do anything strange on re-eval, you have explicitly called for a refreshOnShow so that is what you are going to get when you set focus to that tab.

Regards Fredrik J

comment:3 Changed 12 years ago by (none)

Milestone: 0.3release

Milestone 0.3release deleted

Note: See TracTickets for help on using tickets.