Opened 12 years ago

Closed 11 years ago

Last modified 11 years ago

#6437 closed task (fixed)

nested layout widgets borders should collapse

Reported by: bill Owned by: nonken
Priority: high Milestone: 1.2
Component: Dijit - LnF Version: 1.1.0
Keywords: alex Cc:
Blocked By: Blocking:

Description (last modified by bill)

See the panes tab on test_ExpandoPane.html. It's an AccordionContainer nested inside of a TabContainer. The borders of the TabContainer and the AccordionContainer nest to give an unpleasant effect:

Notice the dark line, which isn't there for other tabs.

Taken from Alex's email.

Attachments (1)

nested.png (12.6 KB) - added by bill 12 years ago.

Download all attachments as: .zip

Change History (14)

Changed 12 years ago by bill

Attachment: nested.png added

comment:1 Changed 12 years ago by bill

Description: modified (diff)

comment:2 Changed 12 years ago by bill

See also #6438; fixing that may make this problem worse.

Also, note that the example list above could be worked-around by adding style="border: none" to the nested AccordionContainer, but for a TabContainer inside an AccordionContainer (the reverse of the example above), I'm not even sure what it should look like. Maybe not worth worrying about.

comment:3 Changed 12 years ago by bill

(In [13897]) Layout widget class changes:

  • Add class attribute to all layout widgets to control class name on domNode (dijitTabContainer, dijitBorderContainer, etc.)
  • Children of layout containers get composite classname specifying parent. ex: a ContentPane? inside of a BorderContainer? will get the class "dijitBorcontainer-dijitContentPane". This is to replace "dijitBorderContainer > dijitContentPane" type selectors which don't work on IE6.
  • refactor of addChild()/removeChild()/_setupChild() to share common code

Refs #6437, #6438 (these changes are necessary to setup CSS rules to get borders to show up correctly for various parent/child relationships)

!strict

comment:4 Changed 12 years ago by nonken

(In [13916]) added ContentPane? styleheet to support nested layouts, refs #6437

comment:5 Changed 12 years ago by nonken

(In [13917]) added ContentPane? specific rules for nested layouts, refs #6437

comment:6 Changed 12 years ago by nonken

(In [13920]) Added Accordion, BorderContainer? rules for nested layouts, refs #6437

comment:7 Changed 12 years ago by nonken

(In [13922]) added test for graphical user interface, refs #6437

comment:8 Changed 11 years ago by nonken

Resolution: fixed
Status: newclosed

This is working now. Missing nested cases for dojox for examples should be filed as new separate tickets.

comment:9 Changed 11 years ago by nonken

Resolution: fixed
Status: closedreopened

Still a few little issues, ignore last note

comment:10 Changed 11 years ago by nonken

(In [14910]) added baseClass for nested layouts, refs #6437 !strict

comment:11 Changed 11 years ago by nonken

Resolution: fixed
Status: reopenedclosed

(In [14911]) fixed CSS for nested layouts, closes #6437

comment:12 Changed 11 years ago by bill

Milestone: 1.31.2

comment:13 Changed 11 years ago by bill

(In [16074]) No children of TabContainer/AccordionContainer? should have a border, since the parent TabContainer/AccordionContainer? supplies a border on it's containerNode. Generalize the no-border rules and move them to dijit.css.

There's still a glitch when the *child* is an AccordionContainer? b/c it's top border comes from a sub-node, not the main DOM node.

Refs #6437.

Note: See TracTickets for help on using tickets.