Opened 12 years ago

Closed 12 years ago

Last modified 11 years ago

#6418 closed defect (fixed)

dojo.query: support of negative a/b in :nth-child(an+b)

Reported by: liucougar Owned by: alex
Priority: high Milestone: 1.2
Component: Query Version: 1.1.0
Keywords: Cc:
Blocked By: Blocking:

Description (last modified by liucougar)

current :nth-child selector in dojo.query does not support negative a or b in form of an+b

dojo.query can not handle contains("bar") either, because it does not remove quotes around bar

in addition, when dojo.query calls dojo.byId, it does not pass in the correct document para (the second argument to dojo.byId)

the attached patch fixes all these issues (also updated test file)

Attachments (1)

6418.patch​ (4.4 KB) - added by liucougar 12 years ago.

Download all attachments as: .zip

Change History (5)

comment:1 Changed 12 years ago by liucougar

Description: modified (diff)
Summary: dojo.query: support of negative a/b in nth-child(an+b) → dojo.query: support of negative a/b in :nth-child(an+b)

Changed 12 years ago by liucougar

Attachment: 6418.patch​ added

comment:2 Changed 12 years ago by dylan

Owner: changed from anonymous to alex

comment:3 Changed 12 years ago by alex

Resolution: → fixed
Status: new → closed

(In [13387]) merging great patch from Liu Cougar for correctly handling the "3n-3" style of CSS selectors and fixing my broken logic on earlier selectors like "0n+1". Fixes #6418. !strict

comment:4 Changed 11 years ago by bill

Component: Core → Query
Note: See TracTickets for help on using tickets.