Opened 11 years ago

Closed 10 years ago

Last modified 8 years ago

#6379 closed enhancement (fixed)

Create a _FormSelectWidget shared class

Reported by: Nathan Toone Owned by: Nathan Toone
Priority: low Milestone: 1.2
Component: Dijit - Form Version: 1.1.0
Keywords: Cc: bill, wolfram
Blocked By: Blocking:

Description

As discussed on IRC 1-Apr-08

similar to how _FormValueWidget wraps an html input element, it would be nice to have a _FormSelectWidget which would basically wrap an html select element. It would probably be used as the core for ComboBox?, FilteringSelect?, and MultiSelect? - as well as DropDownSelect? and CheckedMultiSelect? (in dojox.form).

This class could add functions, such as "addOption", "removeOption", "setSelectedValue", etc - that are helpful for working with select-based widgets

It would also provide for specifying "mutliple=true" and then setting multiple values (instead of a single value).

It might also add support for having as a backend some kind of store to keep track of the options.

This ticket is just a place to add comments/thoughts and to track the status (and any patches) moving towards this idea.

Attachments (1)

FormSelectWidget-6379-2008-07-04_1656.diff (47.4 KB) - added by nathan 11 years ago.
Initial stab at FormSelectWidget? living in dojox.form. This includes its own copy of _HasDropdown.

Download all attachments as: .zip

Change History (13)

comment:1 Changed 11 years ago by nathan

Milestone: 1.2

Changed 11 years ago by nathan

Initial stab at FormSelectWidget? living in dojox.form. This includes its own copy of _HasDropdown.

comment:2 Changed 11 years ago by nathan

Status: newassigned

I figured this would be easier (and probably better, initially) to fix in dojox.form - where there are the select widgets that need it. The main reason for this is due to performance issues with the CheckedMultiSelect?.

This is just an initial attempt at creating a shared FormSelectWidget?.

The patch, however, requires that the patch to #6365 be applied as well...in order to avoid dependencies between patches, this patch contains its own copy of _HasDropDown.js which it uses instead. Once we have both patches merged in, we can fix this.

After working on this a bit, I'm not too sure that there is much that can be shared between it and ComboBox/FilteringSelect?. We might just want to have it continue living in dojox.form for now.

comment:3 Changed 11 years ago by Nathan Toone

(In [13533]) add in support for setting disabled items. Currently this is only implemented in the dropdown widget - due to the way that checkedmultiselect disables itself. refs #6379

comment:4 Changed 11 years ago by Nathan Toone

(In [13549]) added in hook for removing options in a subclass, and fixed issues with getting option 0. refs #6379

comment:5 Changed 11 years ago by nathan

Milestone: 1.21.3

comment:6 Changed 11 years ago by Nathan Toone

Owner: changed from nathan to Nathan Toone
Status: assignednew

comment:7 Changed 11 years ago by Nathan Toone

Reporter: changed from nathan to Nathan Toone

comment:8 Changed 11 years ago by Nathan Toone

(In [14817]) Refs #6379 - should inherit from formvaluewidget

comment:9 Changed 11 years ago by bill

Milestone: 1.3future

comment:10 Changed 10 years ago by Nathan Toone

Milestone: future1.4
Resolution: fixed
Status: newclosed

This has actually existed since the 1.2 timeframe - as dojox.form._FormSelectWidget

comment:11 Changed 10 years ago by bill

Milestone: 1.41.2

comment:12 Changed 8 years ago by bill

Component: DijitDijit - Form
Note: See TracTickets for help on using tickets.