Opened 12 years ago

Closed 11 years ago

#6367 closed defect (fixed)

[patch][ccla] dojox.storage won't load cross-domain in IE6

Reported by: guest Owned by: bradneuberg
Priority: high Milestone: 1.2
Component: Storage/Flash Version: 1.1.0
Keywords: storage xd ie Cc: mpirnat@…
Blocked By: Blocking:

Description

dojox.storage refuses to load from a cross-domain location under IE6; it throws an "Object doesn't support this property or method" exception that the Microsoft script debugger is unable to provide any visibility into, and which seems to be uncatchable by Firebug Lite.

I experimented further by generating a cross-domain build containing a storage layer using the storage profile provided with the buildscripts. Loading that build cross-domain, I was able to get the same error at a slightly different place--it looks like the call to dojo.declare to set up the dojox.storage.FlashStorageProvider? bombs out on the "if(dojo.isArray(superclass)) {" line near the top of dojo.declare.

Attachments (3)

xd_storage_test.html (423 bytes) - added by guest 12 years ago.
Test case that breaks in IE6
storage_patch.txt (10.7 KB) - added by guest 11 years ago.
Patch to let dojox.flash and dojox.storage load XD in IE6
xd_storage.html (444 bytes) - added by guest 11 years ago.
Test page that loads dojox.storage; needs to be hostsed on Domain A and script src tweaked to point to your XD dojo build on Domain B

Download all attachments as: .zip

Change History (12)

Changed 12 years ago by guest

Attachment: xd_storage_test.html added

Test case that breaks in IE6

comment:1 Changed 12 years ago by dylan

Milestone: 1.2
Priority: highnormal
severity: criticalmajor

comment:2 Changed 12 years ago by guest

I've got this fixed under Dojo 1.1.1; I hope to have a patch ready shortly. :-)

-- mpirnat

Changed 11 years ago by guest

Attachment: storage_patch.txt added

Patch to let dojox.flash and dojox.storage load XD in IE6

Changed 11 years ago by guest

Attachment: xd_storage.html added

Test page that loads dojox.storage; needs to be hostsed on Domain A and script src tweaked to point to your XD dojo build on Domain B

comment:3 Changed 11 years ago by guest

My changes against trunk are attached as storage_patch.txt.

The xd_storage.html attachment is the page I've been using to test in IE6. The page needs to be hosted on some domain, and it will need to be modified to point to the correct location of an XD dojo build on some other domain.

Please let me know if there are any issues with it. Otherwise, enjoy. :-)

--mpirnat

comment:4 Changed 11 years ago by guest

Also, in case there's any confusion, my employer (AG Interactive) filed a CCLA last year, so the patch should be kosher for you to either include as-is or modify as needed. Thanks. :-)

-- mpirnat

comment:5 Changed 11 years ago by bradneuberg

Hi mpirnat! Thanks for the patch. I'm not sure it will make the 1.2 release since I'm a bit snowed in at work, but I will apply the patch soon.

comment:6 Changed 11 years ago by dylan

Summary: dojox.storage won't load cross-domain in IE6[patch][needs cla] dojox.storage won't load cross-domain in IE6

mpirnat, can you tell us who you are so we can verify your CLA?

comment:7 Changed 11 years ago by dylan

Summary: [patch][needs cla] dojox.storage won't load cross-domain in IE6[patch][ccla] dojox.storage won't load cross-domain in IE6

Sorry mpirnat, seems I can't read...

comment:8 Changed 11 years ago by Brad Neuberg

I've incorporated the patch; however, the test case given isn't sufficient to really make sure things work, so I'm adapting the Dojo Storage Test to also work cross-domain to make sure the patch works. Still working on it.

comment:9 Changed 11 years ago by Brad Neuberg

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.