Opened 12 years ago

Closed 12 years ago

#6366 closed defect (fixed)

Editor: Toolbar keynav in RTL mode not working

Reported by: davidb Owned by: davidb
Priority: high Milestone: 1.2
Component: Editor Version: 1.1.0
Keywords: bidi Cc:
Blocked By: Blocking:

Description

test_Editor.html?theme=tundra&dir=rtl

In Toolbar's postCreate, isLeftToRight always returns true. Suspicion is that the Toolbar is not yet in the DOM during postCreate in this case.

Attachments (4)

6366.diff (1.6 KB) - added by davidb 12 years ago.
possible fix, adds optional param to Widget's isLeftToRight
6366.2.diff (706 bytes) - added by davidb 12 years ago.
a more minimal fix; not sure if better.
6366.3.diff (1.1 KB) - added by davidb 12 years ago.
a third option which also fixes Editor to call toolbar's startup.
6366.4.diff (806 bytes) - added by davidb 12 years ago.
4th option: modify isLeftToRight impl to use dojo._isBodyLtr (thnx peller)

Download all attachments as: .zip

Change History (9)

comment:1 Changed 12 years ago by Adam Peller

Owner: changed from liucougar to davidb

Changed 12 years ago by davidb

Attachment: 6366.diff added

possible fix, adds optional param to Widget's isLeftToRight

comment:2 Changed 12 years ago by davidb

Tried to move all the key nav setup to startup but Toolbar's startup doesn't fire. I'll investigate further.

Changed 12 years ago by davidb

Attachment: 6366.2.diff added

a more minimal fix; not sure if better.

comment:3 Changed 12 years ago by davidb

Note my first patch needs a 'var' keyword before checkin.

Changed 12 years ago by davidb

Attachment: 6366.3.diff added

a third option which also fixes Editor to call toolbar's startup.

Changed 12 years ago by davidb

Attachment: 6366.4.diff added

4th option: modify isLeftToRight impl to use dojo._isBodyLtr (thnx peller)

comment:4 Changed 12 years ago by davidb

Discussed isLeftToRight with peller today. We need to decide if we need isLeftToRight anymore... and for widgets to store their own _ltr property? Really all that seems needed in current use cases is the document direction.

I removed the call to Toolbar's startup in the latest patch because when/how/why to do that is in question still.

Aside: I'm pinging simonjb on the _KeyNavContainer lifecycle requirements.

comment:5 Changed 12 years ago by davidb

Milestone: 1.1.11.2
Resolution: fixed
Status: newclosed

Fixed via [13274] and [13275]

Note: See TracTickets for help on using tickets.