Opened 11 years ago
Closed 11 years ago
#6366 closed defect (fixed)
Editor: Toolbar keynav in RTL mode not working
| Reported by: | davidb | Owned by: | davidb |
|---|---|---|---|
| Priority: | high | Milestone: | 1.2 |
| Component: | Editor | Version: | 1.1.0 |
| Keywords: | bidi | Cc: | |
| Blocked By: | Blocking: |
Description
test_Editor.html?theme=tundra&dir=rtl
In Toolbar's postCreate, isLeftToRight always returns true. Suspicion is that the Toolbar is not yet in the DOM during postCreate in this case.
Attachments (4)
Change History (9)
comment:1 Changed 11 years ago by
| Owner: | changed from liucougar to davidb |
|---|
Changed 11 years ago by
comment:2 Changed 11 years ago by
Tried to move all the key nav setup to startup but Toolbar's startup doesn't fire. I'll investigate further.
Changed 11 years ago by
| Attachment: | 6366.3.diff added |
|---|
a third option which also fixes Editor to call toolbar's startup.
Changed 11 years ago by
| Attachment: | 6366.4.diff added |
|---|
4th option: modify isLeftToRight impl to use dojo._isBodyLtr (thnx peller)
comment:4 Changed 11 years ago by
Discussed isLeftToRight with peller today. We need to decide if we need isLeftToRight anymore... and for widgets to store their own _ltr property? Really all that seems needed in current use cases is the document direction.
I removed the call to Toolbar's startup in the latest patch because when/how/why to do that is in question still.
Aside: I'm pinging simonjb on the _KeyNavContainer lifecycle requirements.
comment:5 Changed 11 years ago by
| Milestone: | 1.1.1 → 1.2 |
|---|---|
| Resolution: | → fixed |
| Status: | new → closed |
possible fix, adds optional param to Widget's isLeftToRight