#6365 closed enhancement (fixed)
Abstract out a "Drop Down" widget mixin
Reported by: | Nathan Toone | Owned by: | Nathan Toone |
---|---|---|---|
Priority: | low | Milestone: | 1.2 |
Component: | Dijit | Version: | 1.1.0 |
Keywords: | Cc: | bill | |
Blocked By: | Blocking: |
Description
After discussion on IRC, it seems that it might be helpful to have a mixin available for a widget to implement "Drop Down" capabilities.
This ticket is to track thoughts and patches for that idea.
Attachments (3)
Change History (16)
Changed 14 years ago by
Attachment: | HasDropDown.patch added |
---|
comment:1 Changed 14 years ago by
Most of what was included in the first patch is abstraction of stuff in DropDownButton? - the next step, I believe, is to add in the ability to specify a store - in which case, a lot more stuff in ComboBox? can probably be abstracted. I wanted to get this patch up, however, for comments.
comment:2 Changed 14 years ago by
After thinking about it a bit more, I'm thinking that the "store" portion of this would probably be better-implemented as a part of the proposed "_FormSelectWidget" class described in trac #6379
comment:3 Changed 14 years ago by
Milestone: | → 1.2 |
---|
Changed 14 years ago by
Attachment: | 6365-trunk-2008-04-03_1457.diff added |
---|
Updated patch which fixes keystroke issues and updates dojox.form.DropDownSelect? to mix in _HasDropDown as well
comment:4 Changed 14 years ago by
Status: | new → assigned |
---|
Bill - when you get a chance, could you check out this patch and give me some thoughts on it?
Changed 14 years ago by
Attachment: | HasDropdown-6365-trunk-2008-04-04_0743.diff added |
---|
Updated patch to fix state in the mixin - and fix some styling issues in DropDownSelect?
comment:6 Changed 14 years ago by
comment:7 Changed 14 years ago by
Milestone: | 1.2 → 1.3 |
---|
comment:8 Changed 14 years ago by
Owner: | changed from nathan to Nathan Toone |
---|---|
Status: | assigned → new |
comment:9 Changed 14 years ago by
Reporter: | changed from nathan to Nathan Toone |
---|
comment:10 Changed 14 years ago by
Milestone: | 1.3 → future |
---|
comment:11 Changed 13 years ago by
Milestone: | future → 1.4 |
---|---|
Resolution: | → fixed |
Status: | new → closed |
This has actually been fixed since 1.2...in dojox.form._HasDropDown
First stab at an implementation of dijit._HasDropDown - which handles a lot of the dropdown management. This patch also changes dijit.form.DropDownButton? and dijit.form.ComboBox? to mix the class in.