Opened 11 years ago

Closed 10 years ago

Last modified 9 years ago

#6365 closed enhancement (fixed)

Abstract out a "Drop Down" widget mixin

Reported by: Nathan Toone Owned by: Nathan Toone
Priority: low Milestone: 1.2
Component: Dijit Version: 1.1.0
Keywords: Cc: bill
Blocked By: Blocking:

Description

After discussion on IRC, it seems that it might be helpful to have a mixin available for a widget to implement "Drop Down" capabilities.

This ticket is to track thoughts and patches for that idea.

Attachments (3)

HasDropDown.patch​ (27.1 KB) - added by nathan 11 years ago.
First stab at an implementation of dijit._HasDropDown - which handles a lot of the dropdown management. This patch also changes dijit.form.DropDownButton? and dijit.form.ComboBox? to mix the class in.
6365-trunk-2008-04-03_1457.diff​ (29.3 KB) - added by nathan 11 years ago.
Updated patch which fixes keystroke issues and updates dojox.form.DropDownSelect? to mix in _HasDropDown as well
HasDropdown-6365-trunk-2008-04-04_0743.diff​ (38.3 KB) - added by nathan 11 years ago.
Updated patch to fix state in the mixin - and fix some styling issues in DropDownSelect?

Download all attachments as: .zip

Change History (16)

Changed 11 years ago by nathan

Attachment: HasDropDown.patch​ added

First stab at an implementation of dijit._HasDropDown - which handles a lot of the dropdown management. This patch also changes dijit.form.DropDownButton? and dijit.form.ComboBox? to mix the class in.

comment:1 Changed 11 years ago by nathan

Most of what was included in the first patch is abstraction of stuff in DropDownButton? - the next step, I believe, is to add in the ability to specify a store - in which case, a lot more stuff in ComboBox? can probably be abstracted. I wanted to get this patch up, however, for comments.

comment:2 Changed 11 years ago by nathan

After thinking about it a bit more, I'm thinking that the "store" portion of this would probably be better-implemented as a part of the proposed "_FormSelectWidget" class described in trac #6379

comment:3 Changed 11 years ago by nathan

Milestone: → 1.2

Changed 11 years ago by nathan

Attachment: 6365-trunk-2008-04-03_1457.diff​ added

Updated patch which fixes keystroke issues and updates dojox.form.DropDownSelect? to mix in _HasDropDown as well

comment:4 Changed 11 years ago by nathan

Status: new → assigned

Bill - when you get a chance, could you check out this patch and give me some thoughts on it?

Changed 11 years ago by nathan

Attachment: HasDropdown-6365-trunk-2008-04-04_0743.diff​ added

Updated patch to fix state in the mixin - and fix some styling issues in DropDownSelect?

comment:5 Changed 11 years ago by Nathan Toone

(In [13519]) refs #6365: more work on the Drop Down widget mixin

comment:6 Changed 11 years ago by Nathan Toone

(In [13520]) refs #6365: problem with passing in non-value (for separator) as an option

comment:7 Changed 11 years ago by nathan

Milestone: 1.2 → 1.3

comment:8 Changed 11 years ago by Nathan Toone

Owner: changed from nathan to Nathan Toone
Status: assigned → new

comment:9 Changed 11 years ago by Nathan Toone

Reporter: changed from nathan to Nathan Toone

comment:10 Changed 11 years ago by bill

Milestone: 1.3 → future

comment:11 Changed 10 years ago by Nathan Toone

Milestone: future → 1.4
Resolution: → fixed
Status: new → closed

This has actually been fixed since 1.2...in dojox.form._HasDropDown

comment:12 Changed 10 years ago by bill

Milestone: 1.4 → 1.2

See also #9356 about moving it to dijit.

comment:13 Changed 9 years ago by bill

(In [23230]) Remove some code from [13519] for calling _setStateClass() after open/close of drop down. AFAICT opening/closing a drop down does not affect the CSS class on the main widget's DOMNode. (It doesn't seem to affect the classes back at [13519] either.)

Refs #6365, #11251 !strict.

Note: See TracTickets for help on using tickets.