#6359 closed defect (fixed)
[patch] toolbar: (FF3) keyboard use of FilteringSelect scrolls window to hug current selection
| Reported by: | davidb | Owned by: | haysmark |
|---|---|---|---|
| Priority: | high | Milestone: | 1.1.1 |
| Component: | Dijit - Form | Version: | 1.1.0 |
| Keywords: | Cc: | ||
| Blocked By: | Blocking: |
Description (last modified by )
In FF3:
- Open http://archive.dojotoolkit.org/nightly/dojotoolkit/dijit/tests/test_Editor.html
- Put keyboard focus on 3rd toolbar
- Shift-tab when focus is in edit window
- arrow to font combo box
- use down and up arrows
expected: move selection
actual: move selection + scroll window to hug selection
Attachments (1)
Change History (18)
comment:1 Changed 12 years ago by
comment:2 Changed 12 years ago by
| Component: | Editor → Dijit |
|---|---|
| Owner: | changed from liucougar to davidb |
| Status: | new → assigned |
| Summary: | editor: stray keyboard events scroll window → toolbar: stray keyboard events scroll window |
comment:3 Changed 12 years ago by
The ComboBoxMixin? seems to call stopEvent properly. Perhaps dojo.stopEvent is simply failing in FF3?
comment:4 Changed 12 years ago by
dojo.stopEvent is working for me in FF3 in other tests. I can see that it is being called in the described case as well, so I'm not sure why the content scrolls.
comment:5 Changed 12 years ago by
| Summary: | toolbar: stray keyboard events scroll window → toolbar: keyboard use of FilteringSelect scrolls window to hug current selection |
|---|
I'm no longer convinced this is a stray key event problem. Changing description.
comment:6 Changed 12 years ago by
| Description: | modified (diff) |
|---|---|
| Owner: | davidb deleted |
| Status: | assigned → new |
| Summary: | toolbar: keyboard use of FilteringSelect scrolls window to hug current selection → toolbar: (FF3) keyboard use of FilteringSelect scrolls window to hug current selection |
comment:7 Changed 12 years ago by
| Description: | modified (diff) |
|---|
comment:8 Changed 12 years ago by
it may related to timing: try to move the stopEvent as early as possible in the event handler, it may just fix it
comment:10 Changed 12 years ago by
| Owner: | changed from Douglas Hays to haysmark |
|---|
comment:11 Changed 12 years ago by
| Status: | new → assigned |
|---|
The event is being stopped.
The problem is that the dijit.scrollIntoView calls in the ComboBox? menu are not working in FF3. Here is what happens:
- We call dijit.scrollIntoView
- dijit.scrollIntoView gives Mozilla special treatment and calls native scrollIntoView(false) on the menu item
- If the menu item's parent (the menu) has a scrollbar, then everything works great
- If the menu does not have a scrollbar, as is this case, then FF3 looks for the next ancestor and scrolls it. dijit.popup attaches the menu to the body so the whole window scrolls.
My solution: stop giving Mozilla special treatment! I will attach a patch for dijit/_base/scroll.js that fixes the problem for me.
Changed 12 years ago by
| Attachment: | 6359.patch added |
|---|
Fixes #6359. Remove bugged native call to scrollIntoView. All browsers now calculate scrolling into view in the same way.
comment:12 Changed 12 years ago by
| Summary: | toolbar: (FF3) keyboard use of FilteringSelect scrolls window to hug current selection → [patch] toolbar: (FF3) keyboard use of FilteringSelect scrolls window to hug current selection |
|---|
comment:13 Changed 12 years ago by
comment:14 Changed 12 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
comment:15 Changed 12 years ago by
Please verify that we didn't break things for FF2 users with this change.
comment:17 Changed 8 years ago by
| Component: | Dijit → Dijit - Form |
|---|
Note: peller mentioned we use a FilteringSelect? in the FontChoice? plugin. Might be a place to connect some code to stop the event...