Opened 11 years ago

Closed 11 years ago

#6353 closed defect (fixed)

[grid] fix grid code/location issues WRT style guide

Reported by: alex Owned by: alex
Priority: high Milestone: 1.2
Component: DojoX Grid Version: 1.1.0
Keywords: Cc:
Blocked By: Blocking:

Description


Change History (8)

comment:1 Changed 11 years ago by alex

Status: newassigned

comment:2 Changed 11 years ago by Bryan Forbes

(In [13545]) !strict refs #6546

  • Added initial dojo.data notification support (only onSet supported for now).

refs #6353

  • Moved dojox.grid._grid.GridView? to dojox.grid._View (also moved template to resources/View.html).
  • Moved dojox.grid._grid.Views to dojox.grid._ViewManager.
  • Moved dojox.grid._grid.builder classes to private classes in _View.js.
  • Moved functions from dojox.grid.lib that are only used in _View.js to private functions in _View.js.
  • Updated tests accordingly.

comment:3 Changed 11 years ago by Bryan Forbes

(In [13548]) refs #6353 !strict

  • Moved jobs from dojox.grid to private function in VirtualGrid?.js.
  • Moved dojox.grid._grid.Selection to dojox.grid.Selection (and updated tests).
  • Renamed some methods and added range selecting methods in Selection.

comment:4 Changed 11 years ago by Bryan Forbes

(In [13587]) refs #6353 !strict.

  • Moved code used in only one place out of lib.js:
    • Moved focusSelectNode and whenIdle into _data/editors.js.
      • Moved nop into _grid/drag.js.
      • Moved indexInParent, cleanNode, getTagName, nodeKids, and divkids into _Scroller.js.
  • Combined classes defined in _grid/scroller.js into one class in _Scroller.js and removed _grid/scroller.js.
  • Moved _grid/publicEvents.js to _Events.js and added it to the mixin arguments of VirtualGrid?.
  • Changed dojox.grid._Event to a class rather than a plain object so you can use it in dojo.declare's second argument.
  • Updated tests where necessary.

comment:5 Changed 11 years ago by Bryan Forbes

(In [13646]) refs #6353 !strict

  • Moved _grid/cell.js to _Cell.js.
  • Moved _grid/edit.js to _EditManager.js.
  • Moved _grid/focus.js to _FocusManager.js.
  • Moved _grid/lib.js to util.js.
  • Moved _grid/rows.js to _RowManager.js.
  • Moved drag functions into _View.js and removed _grid/drag.js.
  • Removed _grid directory.
  • Updated tests and code with new module names.

comment:6 Changed 11 years ago by Bryan Forbes

(In [13793]) refs #6353 !strict

  • Moved dojox.grid.VirtualGrid? to dojox.grid._Grid.
  • Renamed DataGrid?._getItem to DataGrid?.getItem.
  • Added "defaultValue" property to cells and set it to '...'.
  • Added _Grid._fetch() (stub function).
  • Changed _Grid to work with asyncronous stores more efficiently.

refs #6545

  • Changed "itemAttr" on cells to "field".
  • Added "sortDesc" attribute to cells.

fixes #6746, #5469

  • Fixed horizontal scrolling issue in FF2/3.

comment:7 Changed 11 years ago by Bryan Forbes

(In [13832]) refs #6353, refs #6546 !strict

  • Changed "[mM]odel" to "[sS]tore" in DataGrid?.
  • Updated tests and QueryReadStore? demo to reflect change.
  • Made sure all tests work in IE7.

comment:8 Changed 11 years ago by Bryan Forbes

Resolution: fixed
Status: assignedclosed
Note: See TracTickets for help on using tickets.