Opened 13 years ago
Closed 13 years ago
#6339 closed defect (fixed)
ContentPane parsing of loadingMessage timing
Reported by: | guest | Owned by: | Adam Peller |
---|---|---|---|
Priority: | high | Milestone: | 1.2 |
Component: | Dijit | Version: | 1.0 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description (last modified by )
I've written new Widget which extends TitlePane? which contains ToolBar? in the Title.
When the content loads through href I get:
${loadingState
} as Message until Content loads.
I digged it a bit and found the reason for it is in ContentPane? postCreate Method:
In case href is set and preload=true then the Messages are not initialized this happens because in the postCreate today:
- First we ask:(Here we also preload hrefed content)
if(this.preload){ this._loadCheck(); }
- Second we init the messages
var messages = dojo.i18n.getLocalization("dijit", "loading", this.lang); this.loadingMessage = dojo.string.substitute(this.loadingMessage, messages); this.errorMessage = dojo.string.substitute(this.errorMessage, messages);
By replacing the order(1st Messages init 2nd preload check) fixed the problem. I checked it , it also happends on 1.1b3 it's a small fix I think and not risky.
How to recreate the Defect: In test_TitlePane.html in test #4 add the following: preload="true"
Change History (2)
comment:1 Changed 13 years ago by
Component: | General → Dijit |
---|---|
Description: | modified (diff) |
Milestone: | 1.1.1 → 1.2 |
Owner: | changed from anonymous to Adam Peller |
comment:2 Changed 13 years ago by
Description: | modified (diff) |
---|---|
Resolution: | → fixed |
Status: | new → closed |
fixed by [13243]