Opened 11 years ago
Closed 11 years ago
#6319 closed defect (fixed)
Make dojox.form.DropDownSelect not throw deprecated messages on setValue() calls
| Reported by: | nathan | Owned by: | nathan |
|---|---|---|---|
| Priority: | low | Milestone: | 1.2 |
| Component: | DojoX Form | Version: | 1.1b1 |
| Keywords: | Cc: | ||
| Blocked By: | Blocking: |
Description (last modified by )
dojox.form.DropDownSelect? inherit from dijit.form.DropDownButton? - and, as such, its setValue() function is deprecated in 1.1. This needs to be changed so that the deprecation message doesn't happen.
Attachments (1)
Change History (8)
comment:1 Changed 11 years ago by
| Owner: | set to Douglas Hays |
|---|
comment:2 Changed 11 years ago by
| Resolution: | → invalid |
|---|---|
| Status: | new → closed |
comment:3 Changed 11 years ago by
| Component: | Dijit → DojoX Form |
|---|---|
| Description: | modified (diff) |
| Resolution: | invalid |
| Status: | closed → reopened |
| Summary: | Future-proof dijit.form.Form.setValues() → Make dojox.form.DropDownSelect not throw deprecated messages on setValue() calls |
OK - error on my part. The problem that I was seeing was specifically with dojox.form.DropDownSelect? - which is extended from dijit.form.DropDownButton? (hence the deprecation warning on that specific one). As I was tracing it back, I saw that the deprecation message was coming from dijit.form._FormWidget - and didn't notice that dijit.form._FormValueWidget overrides it.
Updating this issue to be specific to dojox.form.DropDownSelect?.
comment:4 Changed 11 years ago by
| Owner: | changed from Douglas Hays to nathan |
|---|---|
| Status: | reopened → new |
Changed 11 years ago by
| Attachment: | DropDownSelect.patch added |
|---|
Makes DropDownSelect? behave more like a _FormValueWidget rather than a _FormWidget (not deprectaed getValue/setValue, etc)
comment:5 Changed 11 years ago by
| Owner: | changed from nathan to dante |
|---|
Reassigning to Dante for proxy commit
comment:6 Changed 11 years ago by
| Owner: | changed from dante to nathan |
|---|---|
| Status: | new → assigned |
comment:7 Changed 11 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Fixed in changeset 13253
I don't understand. setValue is not deprecated for anything other than button widgets and setAttribute('value') only works properly for checkbox widget and doesn't set the checkbox boolean widget value.