Opened 12 years ago

Last modified 12 years ago

#6307 closed defect

Textarea/TextBox: better font, font-size, and spacing (as default for tundra, soria, etc) — at Version 9

Reported by: alex Owned by: nonken
Priority: high Milestone: 1.2
Component: Dijit - LnF Version: 1.0
Keywords: L&F, look, feel, UI Cc: alex
Blocked By: Blocking:

Description (last modified by bill)

the inner padding and lineheight rules for the textarea widget give it a cramped an unreadable feeling WRT native textarea widgets.

Native textarea:

Textarea widget:

As per April 8 dijit meeting, I'm expanding this ticket to include the TextBox widgets as well as the TextArea and SimpleTextArea.

The decision is to make dijit "look good out of the box" in preference to supporting inheritance of font and font-size, which in this case means

  • to remove the IE expressions for font/font-size inheritance ([12806])
  • just hardcode values of font for textarea and textbox widgets (probably sans-serif)
  • hardcode a font-size too (but for a11y reasons use em or a word like "medium", rather than pt or px).
  • I think that means we can remove the workaround checked in for [13214] (references #6220) and also in [13158] (references #6262).

Change History (11)

Changed 12 years ago by alex

Attachment: cramped1.tiff added

Changed 12 years ago by alex

Attachment: cramped2.tiff added

comment:1 Changed 12 years ago by bill

Description: modified (diff)
Summary: textarea widget text spacing is crampedTextarea: text spacing is cramped

comment:2 Changed 12 years ago by bill

Component: DijitDijit - LnF

comment:3 Changed 12 years ago by Adam Peller

Description: modified (diff)
Owner: set to Douglas Hays

comment:4 Changed 12 years ago by Douglas Hays

Am I supposed to change the default tundra font-family for Textarea to monospace? I don't think we should override the default font set by the user for the document. Firefox2 Textarea widget doesn't inherit the user font - this should be changed.

comment:5 Changed 12 years ago by bill

Milestone: 1.1.11.2

Let's think about this some before implementing anything. As my prime rule, I'd like diijit to look good out-of-the-box, but it's unclear what "good" means for textareas. Note that native textareas look different on different browsers. The screenshot above is from Safari. On IE and FF, they use a monospace font. (Strangely, plain <input> nodes don't use a monospace font.)

comment:6 Changed 12 years ago by Douglas Hays

Owner: changed from Douglas Hays to nonken

comment:7 Changed 12 years ago by bill

Description: modified (diff)
Summary: Textarea: text spacing is crampedTextarea/TextBox: better font, font-size, and spacing (as default for tundra, soria, etc)

As per April 8 dijit meeting, I'm expanding this ticket to include the TextBox widgets as well as the TextArea and SimpleTextArea. Changing description...

comment:8 Changed 12 years ago by bill

Description: modified (diff)

comment:9 Changed 12 years ago by bill

Description: modified (diff)
Note: See TracTickets for help on using tickets.