Opened 13 years ago

Closed 13 years ago

Last modified 10 years ago

#6292 closed defect (duplicate)

[patch][cla] dijit.form.Form + onSubmit broken

Reported by: guest Owned by: bill
Priority: high Milestone: 1.1
Component: Dijit - Form Version: 1.1b1
Keywords: Cc: [email protected]…
Blocked By: Blocking:

Description

Problem occurs in dojo 1.1 RC1. When submitting a form using an <input type='submit' /> or dojo.byId("formWidget").submit(); the form will submit regardless of weather or not the onSubmit method defined in the widget returns false. I've attached a patch that fixes this. I have a CLA signed under the name of William Riley.

Attachments (1)

formPatch.diff​ (1013 bytes) - added by guest 13 years ago.
Patch for dijit.form.Form

Download all attachments as: .zip

Change History (6)

Changed 13 years ago by guest

Attachment: formPatch.diff​ added

Patch for dijit.form.Form

comment:1 Changed 13 years ago by Robert Coup

Component: General → Dijit
Owner: changed from anonymous to bill
Summary: dijit.form.Form + onSubmit broken → [patch][cla] dijit.form.Form + onSubmit broken

updates as per psychf's request.

comment:2 Changed 13 years ago by Douglas Hays

This is a dup of #6280. This patch doesn't fix the underlying problem with dojo.attr.

comment:3 Changed 13 years ago by bill

Resolution: → duplicate
Status: new → closed

comment:4 Changed 13 years ago by bill

(In [13191]) Patch from Doug to make onsubmit="return false;" work on dijit.Form (in addition to dojo.stopEvent()), like on native <form> elements. Fixes #6299, refs #6280, #6292.

comment:5 Changed 10 years ago by bill

Component: Dijit → Dijit - Form
Note: See TracTickets for help on using tickets.