#6282 closed defect (fixed)
[patch] [cla] TimePicker styling
Reported by: | nathan | Owned by: | nathan |
---|---|---|---|
Priority: | high | Milestone: | 1.2 |
Component: | Dijit | Version: | 1.0 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description (last modified by )
dijit._TimePicker is UGLY (no offense)!
It doesn't have stylings for the themes (just the default stylings), and it jumps around because of the "zoom" feature.
Suggestions:
- Make "default" styling more "default" (simliar to how calendar looks)
- Make per-theme stylings to be consistent with other widgets
- Implement zooming on a per-theme basis, rather than in the default styling ("default" should be the bare-minimum...nothing fancy)
- Change the up/down buttons to mirror the classes for arrows on buttons so that the theme styles for those apply.
- Add some hover-state classes to be able to avoid ".class1.class2" type selectors (which are not supported in IE6)
Change History (8)
comment:1 Changed 13 years ago by
Description: | modified (diff) |
---|
comment:2 Changed 13 years ago by
Summary: | TimePicker styling → [patch] TimePicker styling |
---|
comment:3 Changed 13 years ago by
Summary: | [patch] TimePicker styling → [patch] [cla] TimePicker styling |
---|
comment:4 Changed 13 years ago by
Description: | modified (diff) |
---|---|
Status: | new → assigned |
comment:5 Changed 13 years ago by
comment:6 Changed 13 years ago by
The patch attached on 4/4 has issues in high contrast mode. When I mouse over one of the in-between times to make it visiable, the text barely fits within the top and bottom borders - it needs some padding in order to be readable. This worked ok in high contrast mode in 1.0.2 - there was padding between the time text and the top and bottom border in both high contrast and non-high contrast mode.
comment:7 Changed 13 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Fixed (including a11y issues) in 13264
Note: See
TracTickets for help on using
tickets.
Whoa! Where'd my patch go???
There are problems with this bug attaching patches. The patch for this bug can be found at http://www.toonetown.com/projects/downloads/TimePicker.patch