Unable to prevent form submit

[guest]

I am unable to prevent the form submit process on IE7 only. It works fine on ie6, firefox. Problem seen with 1.1b3 and 1.1rc1

 <form dojoType="dijit.form.Form" id="myForm" onSubmit="return false;">

       <input id="idSearch" type="text" dojotype="dijit.form.TextBox" name="line" style="width: 12em" trim="true"  />
          <button dojoType="dijit.form.Button"   type="submit">
	No submit 
	</button>                    
    </form>

[Douglas Hays]

regression in [12067]

[Douglas Hays]

Sorry, about the prior post but I was only looking at dijit changes before.
If I take the current trunk and roll back only dojo/_base/html.js to [12893] then it works. Probably the ability of dojo.attr to handle value types of function is broken.

[Douglas Hays]

Run dijit/demos/form.html on any browser
Press OK. Press Cancel to not submit the form, but the submit proceeds.

[Douglas Hays]

dojo.attr was changed in revision [12899] to use connect for function values. But this doesn't work for functions like onsubmit and onreset that have to return a boolean that tell the browser whether to proceed or not. There may be other functions that work the same as well (onclick?).

[bill]

See also #6292, a dup of this.

[alex]

doughays: using dojo.connect() for those events allows us to handle cancelation in a uniform way. The preferred syntax for the above is:

 <form dojoType="dijit.form.Form" id="myForm" onSubmit="dojo.stopEvent(arguments[0]);">

Which will call dojo.stopEvent() on the passed event object on all browsers which I've tested on. I'll update the docs on dojo.attr()'s behavior and also add a test cage for this use-case, but fundamentally it's not a bug.

Regards

[alex]

(In [13181]) update docs and default behavior for dijit.Form and dojo.attr to make it crystal clear that unified Dojo event handling is in play when using event handlers specified by dojo.attr() and that browser-specific hacks may no longer work as expected. Fixes #6280. !strict

[bill]

(In [13191]) Patch from Doug to make onsubmit="return false;" work on dijit.Form (in addition to dojo.stopEvent()), like on native <form> elements. Fixes #6299, refs #6280, #6292.