Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#6257 closed defect (fixed)

[patch] test_Editor.html throws an error in IE7 (FontChoice plugin)

Reported by: Bryan Forbes Owned by: alex
Priority: high Milestone: 1.1
Component: Editor Version: 1.1b1
Keywords: patch Cc:
Blocked By: Blocking:

Description

While trying to debug some Editor anomalies, I ran across a bug in the FontChoice? plugin where the value in the updateState() method has the indexOf method run on it before checking if it's a string. IE7 returns an integer from _e.queryCommandValue(), so the indexOf call throws an error. I'm attaching a patch to fix this for IE7.

Attachments (1)

editor_fix.diff​ (650 bytes) - added by Bryan Forbes 11 years ago.

Download all attachments as: .zip

Change History (3)

Changed 11 years ago by Bryan Forbes

Attachment: editor_fix.diff​ added

comment:1 Changed 11 years ago by alex

Resolution: → fixed
Status: new → closed

(In [13146]) merging patch from Bryan Forbes to fix FontChoice? exception. Fixes #6257

comment:2 Changed 11 years ago by Adam Peller

(In [13154]) Don't process font size pixel map unless the value is in pixels. Fixes #6257

Note: See TracTickets for help on using tickets.