Opened 12 years ago

Closed 11 years ago

#6250 closed defect (fixed)

[patch] Create auto scrolling TimeTextBox widget

Reported by: nathan Owned by: nathan
Priority: high Milestone: 1.2
Component: DojoX Form Version: 1.0
Keywords: Cc: haysmark
Blocked By: Blocking:

Description (last modified by nathan)

It's a more "natural" way of doing things, the clicks would still works, but it would be nice to have it autoscroll when hovering over the buttons.

The hover-based scroll would probably fire a bit sooner, and wouldn't accelerate quite as much.

Attachments (1)

TimeTextBox.patch (7.2 KB) - added by nathan 12 years ago.
Implements a dojox.form.TimeTextBox? widget (really, it just extends dijit._TimePicker). Also includes a test case - which is mostly a copy of dijit/tests/form/test_TimeTextBox.html

Download all attachments as: .zip

Change History (17)

comment:1 Changed 12 years ago by nathan

Description: modified (diff)

comment:2 Changed 12 years ago by nathan

Summary: Make dijit._TimePicker scroll automatically on hover of the up or down buttons[patch] Make dijit._TimePicker scroll automatically on hover of the up or down buttons

comment:3 Changed 12 years ago by Adam Peller

Cc: haysmark added
Owner: changed from nathan to haysmark

comment:4 Changed 12 years ago by Douglas Hays

Milestone: 1.2

comment:5 Changed 12 years ago by nathan

Component: DijitDojoX Form
Owner: changed from haysmark to nathan

Moving to dojox.form - probably should exist there for some "bake time".

comment:6 Changed 12 years ago by nathan

Summary: [patch] Make dijit._TimePicker scroll automatically on hover of the up or down buttonsCreate auto scrolling TimeTextBox widget

comment:7 Changed 12 years ago by Douglas Hays

Want to make sure that hovering over the buttons doesn't cause autoscroll to happen, and then refire again since you may still be hovering over the button in the case of several pages and no scrollbar.

Changed 12 years ago by nathan

Attachment: TimeTextBox.patch added

Implements a dojox.form.TimeTextBox? widget (really, it just extends dijit._TimePicker). Also includes a test case - which is mostly a copy of dijit/tests/form/test_TimeTextBox.html

comment:8 Changed 12 years ago by nathan

Milestone: 1.21.1
Summary: Create auto scrolling TimeTextBox widget[patch] Create auto scrolling TimeTextBox widget

Created patch with the fix implemented in dojox.form.

comment:9 in reply to:  7 Changed 12 years ago by nathan

Replying to doughays:

Want to make sure that hovering over the buttons doesn't cause autoscroll to happen, and then refire again since you may still be hovering over the button in the case of several pages and no scrollbar.

Yeah - the way that scrolling is implemented in dijit._TimePicker isn't really "scrolling". On click of the buttons, it just redraws the content (and only the visible content is drawn). This allows for wrap-around scrolling.

The patch here just kicks off a typematic trigger on hover of the button - the same as it would fire off on click of the button.

comment:10 Changed 12 years ago by nathan

Description: modified (diff)
Owner: changed from nathan to dante

comment:11 Changed 12 years ago by nathan

Reassigning to Dante for proxy commit

comment:12 Changed 12 years ago by nathan

Owner: changed from dante to nathan
Status: newassigned

comment:13 Changed 12 years ago by nathan

Having problems attaching patches to this bug as well.... There is a patch at http://www.toonetown.com/projects/downloads/TimePicker_HoverScroll-6250-04-04_1343.diff

which puts this mechanism back in dijit as an option to be passed to dijit._TimePicker (hoverScroll=true) - defaults to false. Also contains a test case for setting it to true.

comment:14 Changed 12 years ago by nathan

Resolution: fixed
Status: assignedclosed

Fixed in [13267]

comment:15 Changed 12 years ago by nathan

Resolution: fixed
Status: closedreopened

Reopening until we can get a consensus on what should happen here with the TimePicker?.

comment:16 Changed 11 years ago by Nathan Toone

Resolution: fixed
Status: reopenedclosed

(In [13450]) Fixes #6250: hoverScroll on by default - not as an option

Note: See TracTickets for help on using tickets.