Opened 12 years ago
Closed 12 years ago
#6250 closed defect (fixed)
[patch] Create auto scrolling TimeTextBox widget
| Reported by: | nathan | Owned by: | nathan |
|---|---|---|---|
| Priority: | high | Milestone: | 1.2 |
| Component: | DojoX Form | Version: | 1.0 |
| Keywords: | Cc: | haysmark | |
| Blocked By: | Blocking: |
Description (last modified by )
It's a more "natural" way of doing things, the clicks would still works, but it would be nice to have it autoscroll when hovering over the buttons.
The hover-based scroll would probably fire a bit sooner, and wouldn't accelerate quite as much.
Attachments (1)
Change History (17)
comment:1 Changed 12 years ago by
| Description: | modified (diff) |
|---|
comment:2 Changed 12 years ago by
| Summary: | Make dijit._TimePicker scroll automatically on hover of the up or down buttons → [patch] Make dijit._TimePicker scroll automatically on hover of the up or down buttons |
|---|
comment:3 Changed 12 years ago by
| Cc: | haysmark added |
|---|---|
| Owner: | changed from nathan to haysmark |
comment:4 Changed 12 years ago by
| Milestone: | → 1.2 |
|---|
comment:5 Changed 12 years ago by
| Component: | Dijit → DojoX Form |
|---|---|
| Owner: | changed from haysmark to nathan |
comment:6 Changed 12 years ago by
| Summary: | [patch] Make dijit._TimePicker scroll automatically on hover of the up or down buttons → Create auto scrolling TimeTextBox widget |
|---|
comment:7 follow-up: 9 Changed 12 years ago by
Want to make sure that hovering over the buttons doesn't cause autoscroll to happen, and then refire again since you may still be hovering over the button in the case of several pages and no scrollbar.
Changed 12 years ago by
| Attachment: | TimeTextBox.patch added |
|---|
Implements a dojox.form.TimeTextBox? widget (really, it just extends dijit._TimePicker). Also includes a test case - which is mostly a copy of dijit/tests/form/test_TimeTextBox.html
comment:8 Changed 12 years ago by
| Milestone: | 1.2 → 1.1 |
|---|---|
| Summary: | Create auto scrolling TimeTextBox widget → [patch] Create auto scrolling TimeTextBox widget |
Created patch with the fix implemented in dojox.form.
comment:9 Changed 12 years ago by
Replying to doughays:
Want to make sure that hovering over the buttons doesn't cause autoscroll to happen, and then refire again since you may still be hovering over the button in the case of several pages and no scrollbar.
Yeah - the way that scrolling is implemented in dijit._TimePicker isn't really "scrolling". On click of the buttons, it just redraws the content (and only the visible content is drawn). This allows for wrap-around scrolling.
The patch here just kicks off a typematic trigger on hover of the button - the same as it would fire off on click of the button.
comment:10 Changed 12 years ago by
| Description: | modified (diff) |
|---|---|
| Owner: | changed from nathan to dante |
comment:12 Changed 12 years ago by
| Owner: | changed from dante to nathan |
|---|---|
| Status: | new → assigned |
comment:13 Changed 12 years ago by
Having problems attaching patches to this bug as well.... There is a patch at http://www.toonetown.com/projects/downloads/TimePicker_HoverScroll-6250-04-04_1343.diff
which puts this mechanism back in dijit as an option to be passed to dijit._TimePicker (hoverScroll=true) - defaults to false. Also contains a test case for setting it to true.
comment:15 Changed 12 years ago by
| Resolution: | fixed |
|---|---|
| Status: | closed → reopened |
Reopening until we can get a consensus on what should happen here with the TimePicker?.
comment:16 Changed 12 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | reopened → closed |
Moving to dojox.form - probably should exist there for some "bake time".