Opened 14 years ago

Closed 12 years ago

#6240 closed defect (fixed)

put DND CSS classes into theme

Reported by: bill Owned by: nonken
Priority: high Milestone: 1.5
Component: Dijit - LnF Version: 1.0
Keywords: Cc: Eugene Lazutkin
Blocked By: Blocking:

Description (last modified by bill)

Currently the unofficial "theme" for DND is defined in source:dojo/trunk/tests/dnd/dndDefault.css but it should be part of each theme for dijit.

Also, could cleanup the CSS some. For example, the avatar has a rectangle surrounded by a rounded rectangle (Eugene says this looks really bad.)

It's also possible using simple CSS rules that during drag, to tone down all irrelevant elements on the page highlighting all valid targets, which is a good usability feature especially for visually impaired .

Note that the themes do already have some DnD classes, see source:dijit/trunk/themes/tundra/Common.css, but it doesn't define things like dojoDndItemSelected. In any case, source:dijit/trunk/tests/test_Tree_Notification_API_Support.html and source:dijit/trunk/tests/tree/test_Tree_DnD.html should not be importing dndDefault.css.

Change History (11)

comment:1 Changed 14 years ago by bill

Description: modified (diff)

comment:2 Changed 14 years ago by bill

Component: DijitDijit - LnF

comment:3 Changed 14 years ago by Eugene Lazutkin

Description: modified (diff)

#6395 is the dup. But it assumes the default DnD CSS, which will be overridden by themes.

comment:4 Changed 14 years ago by nonken

Milestone: 1.2tbd
Status: newassigned

To enable easier styling we need to put a separate "test" with the markup being statically on a page, it is very hard otherwise to style and improve the interface

comment:5 Changed 14 years ago by dylan

Milestone: tbdfuture

comment:6 Changed 14 years ago by nonken

Milestone: future1.3

comment:7 Changed 14 years ago by bill

Milestone: 1.31.4

comment:8 Changed 14 years ago by bill

Description: modified (diff)

Some of the DnD stuff is already in source:dijit/trunk/themes/tundra/Common.css, but comparing to source:dojo/trunk/tests/dnd/dndDefault.css I guess some still needs to be copied.

comment:10 Changed 13 years ago by bill

Milestone: 1.41.5
Priority: highnormal

comment:11 Changed 12 years ago by bill

Resolution: fixed
Status: assignedclosed

I'm going to mark this as closed, the themes do have DnD CSS rules (and themeTester.html even has a DnD tab). As for styling, claro has slightly revised the style of the avatar.

Note: See TracTickets for help on using tickets.