[patch][ccla]ComboBox does not load item, when selecting a value with the keyboard

[John Locke]

1. Create a data store-backed ComboBox?.

2. Select an item from the list by typing a value, then use the mouse to select an item in the list.

3. Trigger a script, and attempt to get values from the store using code like the following:

var cb = dijit.byId('mycombobox');
var source = cb.store.getValue(cb.item, 'source');

Result: "source" is set to the value looked up in the data store associated with the selected item.

4. Repeat the above, only this time in step 2 use the keyboard to select an item (use up/down arrows, enter, tab).

Result: cb.item evaluates to false, not able to access other data in the store item.

Tested on FF2/Linux, Dojo 1.1.0b3.

[John Locke]

ok, so it may not be the keyboard selection causing the problem, so much as blurring the field.

When the field is selected and I click the button that triggers my script, ComboBox?.item is set. If I tab out of the field, ComboBox?.item gets cleared. I'd like to see this remain set after an item is selected...

FilteringSelect? has this same behavior.

[Douglas Hays]

This may be a regression from #4872. wolfram, can you check to see if moving

this.item = null; // #4872

from _onKeyPress() to the start of _startSearch() fixes both problems?

[John Locke]

Hi,

The proposed fix works fine for me here. I moved the line above to line 529 in the current trunk, and no problems so far.

Thanks, John

[Douglas Hays]

waiting on verification from wolfram that #4872 is not regresed by this patch (refreshed)

[wolfram]

looks good from my side. go ahead and commit it ... I added another fix, which reset the item properly when reset() is called, which was not the case until now. thx

[Douglas Hays]

(In [13113]) Fixes #6197. Proxy commit for wolfram. Resets the item attribute only on new searches and reset() instead on every keystroke.