Opened 14 years ago
Closed 14 years ago
#6189 closed defect (fixed)
[patch] ComboBox/Editor: various height elements not working
Reported by: | bill | Owned by: | haysmark |
---|---|---|---|
Priority: | high | Milestone: | 1.2 |
Component: | Dijit - LnF | Version: | 1.1b1 |
Keywords: | Cc: | nonken | |
Blocked By: | Blocking: |
Description (last modified by )
Attachments (3)
Change History (8)
Changed 14 years ago by
Attachment: | fontSize.gif added |
---|
comment:1 Changed 14 years ago by
Component: | Dijit → Dijit - LnF |
---|
comment:2 Changed 14 years ago by
Description: | modified (diff) |
---|
It has to do with this code in dojo/resources/dojo.css:
ol li, ul li { font-size:1em; line-height:1.5em; margin:0pt; }
When I turn off font-size and line-height in Firebug I get a very different-looking menu.
Changed 14 years ago by
Attachment: | fixedpopup.jpg added |
---|
Same popup without global dojo.css li rules.
comment:3 Changed 14 years ago by
Cc: | nonken added |
---|---|
Milestone: | 1.3 → 1.2 |
Ah thanks for finding this. Hmm, I'm not sure how we should address this. Options are:
- modify dojo.css, either
- removing that line-height rule since it will also mess up developers that setup a different font-size on their lists w/out adjusting line-height too.
- Alternately, could it be changed to use margin or padding rather than line-height?
- override that setting for ComboBox's drop down
- override that setting just for the Editor
- something else
Changed 14 years ago by
Attachment: | 6189.patch added |
---|
Fixes #6189. Set the line-height on each of the options in ComboBoxMenu? to normal.
comment:4 Changed 14 years ago by
Status: | new → assigned |
---|---|
Summary: | ComboBox/Editor: various height elements not working → [patch] ComboBox/Editor: various height elements not working |
IMO setting global styles in dojo.css seems pretty wonky to me, but here is a patch to fix ComboBoxMenu?.
comment:5 Changed 14 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
(In [14295]) Fixes #6189: ComboBox/Editor?: various height elements not working
Note: See
TracTickets for help on using
tickets.
screenshot