Opened 12 years ago

Closed 12 years ago

Last modified 7 years ago

#6186 closed defect (fixed)

Dialog: ESC key on non-drop-down field closes dialog instead of calling undo (IE)

Reported by: Douglas Hays Owned by: Douglas Hays
Priority: high Milestone: 1.2
Component: Dijit Version: 1.0
Keywords: Cc:
Blocked By: Blocking:

Description (last modified by Douglas Hays)

Run test_dialog.html using IE
Open the first dialog.
Type a value in the first input box and press ESC.
The value should go back to blank, but the dialog closes.
This seems to only be a problem with IE.

Change History (9)

comment:1 Changed 12 years ago by bill

Summary: IE: ESC key closes dialog instead of calling undoDialog: ESC key closes dialog instead of calling undo (IE)

comment:2 Changed 12 years ago by bill

Summary: Dialog: ESC key closes dialog instead of calling undo (IE)Dialog: ESC key on non-drop-down field closes dialog instead of calling undo (IE)

comment:3 Changed 12 years ago by bill

Resolution: fixed
Status: newclosed

(In [13065]) Fixes #5859, #6186: problems with initial BorderContainer? sizing on IE. Setting the size of a node and then immediately querying the size sometimes doesn't work (plus which it's inefficient). Fixed that for IE although not for other browsers. (IE is a separate code path since it doesn't use t/l/b/r four-corners setting for styling.) !strict

comment:4 Changed 12 years ago by Douglas Hays

Resolution: fixed
Status: closedreopened

Not fixed by [13065]

comment:5 Changed 12 years ago by Douglas Hays

Description: modified (diff)
Resolution: fixed
Status: reopenedclosed

Fixed by [13769].

comment:6 Changed 12 years ago by bill

Actually, fixed by [13759].

comment:7 Changed 11 years ago by bill

Note: the checkin comment for [13065] was incorrect, it fixes #6168 not this ticket.

comment:8 Changed 7 years ago by bill

In [30842]:

Remove some code from [13759] that's apparently no longer needed, refs #6186 !strict. We used to have code where the ESC key would reset a form field (rather than closing the Dialog), but we removed it a long time ago. Plus which, in 1.9 I changed all the dijit code to use keydown rather than keypress.

comment:9 Changed 7 years ago by bill

In [31401]:

remove no-longer used dependency after [30842], refs #6186 !strict

Note: See TracTickets for help on using tickets.