Opened 14 years ago

Closed 13 years ago

Last modified 12 years ago

#617 closed enhancement (fixed)

[patch][cla] Drag multiple objects programmatically and decouple event calls

Reported by: wolfram.kriesing@… Owned by: Bryan Forbes
Priority: high Milestone:
Component: General Version: 0.2
Keywords: Cc: alex
Blocked By: Blocking:

Change History (12)

comment:1 Changed 14 years ago by wolfram.kriesing@…

Cc: alex added

Alex could you please validate this in the HtmlDragManager?.diff? I dont know why there was a check for length==1 before, seems useless to me, or should it be >=1 ? but that would be useless since it is inside a if(this.selectedSources.length)

@@ -304,10 +336,11 @@
 				dy = mouse.y - this.mouseDownY;
 			}
 
-			if (this.selectedSources.length == 1) {
-				this.dragSource = this.selectedSources[0];
-			}
-
+			// the first element is always our dragSource, if there are multiple
+			// selectedSources (elements that move along) then the first one is the master
+			// and for it the events will be fired etc.
+			this.dragSource = this.selectedSources[0];
+			

comment:2 Changed 14 years ago by alex

Milestone: 0.3release
Owner: changed from anonymous to alex
Status: newassigned

Wolfram, thanks for submitting these patches. Have you filed a CLA?

comment:3 Changed 14 years ago by alex

Priority: normalhigh

CLA has been filed. Confirming for 0.3 inclusion.

comment:4 Changed 14 years ago by alex

Milestone: 0.3release0.3.1

punting to 0.3.1 because we were to slow in getting it in for testing in 0.3.0. = (

comment:5 Changed 14 years ago by alex

Owner: changed from alex to sjmiles
Status: assignednew

comment:6 Changed 13 years ago by anonymous

Milestone: 0.3.10.4

Committed the patch, but we need a test case and some improvements.

comment:7 Changed 13 years ago by anonymous

Type: defectenhancement

comment:8 Changed 13 years ago by sjmiles

Owner: changed from sjmiles to anonymous

comment:9 Changed 13 years ago by dylan

Owner: changed from anonymous to Bryan Forbes

needs testing

comment:10 Changed 13 years ago by dylan

Summary: Drag multiple objects programmatically and decouple event calls[patch][cla] Drag multiple objects programmatically and decouple event calls

comment:11 Changed 13 years ago by Bryan Forbes

Description: modified (diff)
Resolution: fixed
Status: newclosed

comment:12 Changed 12 years ago by (none)

Milestone: 0.4

Milestone 0.4 deleted

Note: See TracTickets for help on using tickets.