Opened 13 years ago

Closed 13 years ago

Last modified 12 years ago

#616 closed defect (fixed)

Modify ContentPane link processing to skip #anchor-style links

Reported by: anonymous Owned by: anonymous
Priority: high Milestone:
Component: Widgets Version: 0.3
Keywords: Cc: jeoffwilks@…
Blocked By: Blocking:

Description

Pages loaded in ContentPane? have their anchor links modified so that they "break out" of the content pane and load a new page instead.

This proposed patch to source:/trunk/src/widget/html/ContentPane.js would prevent it from processing anchor tags:

case "href":
    if(attr[3].charAt(0)=='#'){   //skip anchor tags!
        fixedPath = attr[3];
    } else if(attr[3].search(/^(https?|ftps?|file|javascript|mailto|news):/)==-1){
        fixedPath = (new dojo.uri.Uri(url, attr[3]).toString());
    } else {
        fixedPath = attr[3];
    }
    break;

Change History (4)

comment:1 Changed 13 years ago by anonymous

Cc: jeoffwilks@… added
Milestone: 0.3release
Version: 0.3

comment:2 Changed 13 years ago by anonymous

Owner: changed from mumme to anonymous
Status: newassigned

I'm happy to merge this. Have you submitted a CLA? http://dojotoolkit.org/icla.txt

comment:3 Changed 13 years ago by mumme@…

Resolution: fixed
Status: assignedclosed

Fixed as of rev 3565.

Modified test_RemotePaths.html to include anchortags.

Thank you for finding this!

Regards Fredrik Johansson

comment:4 Changed 12 years ago by (none)

Milestone: 0.3release

Milestone 0.3release deleted

Note: See TracTickets for help on using tickets.