#6151 closed defect (fixed)
Button: unequal height of buttons
| Reported by: | bill | Owned by: | nonken |
|---|---|---|---|
| Priority: | high | Milestone: | 1.6 |
| Component: | Dijit - LnF | Version: | 1.0 |
| Keywords: | Cc: | ||
| Blocked By: | Blocking: |
Description (last modified by )
See themeTester.html.
Even if I change the test to use the same icon for all the buttons, the DropDownButton and !Button are taller than the ComboButton on IE. It's a slight difference, maybe 3px:
(Note that the plus icon and note icon seem to be a different size... that's just a test file problem but please fix that too... however the main point of this ticket is that even when the icon is the same, the button heights are different.)
Attachments (1)
Change History (11)
Changed 12 years ago by
| Attachment: | buttons.gif added |
|---|
comment:1 Changed 12 years ago by
| Description: | modified (diff) |
|---|
comment:2 Changed 12 years ago by
| Description: | modified (diff) |
|---|
comment:3 Changed 12 years ago by
| Component: | Dijit → Dijit - LnF |
|---|
comment:4 Changed 12 years ago by
| Description: | modified (diff) |
|---|
As per email thread, this seems to be because ComboButton doesn't contain a <button> node. To quote Doug:
I think ComboButton should have a table with a button node on the left and a non-button on the right. I couldn't get this to size correctly but that was a long time ago. Maybe a fresh try by Nikolai will be successful.
comment:5 Changed 12 years ago by
| Status: | new → assigned |
|---|
comment:6 Changed 11 years ago by
| Milestone: | 1.3 → 1.4 |
|---|
comment:7 Changed 11 years ago by
patch in #6150 fixes the ComboButton? height - not the margin problem and the ToggleButton? is still hs a different height.
comment:8 Changed 10 years ago by
| Milestone: | 1.4 → 1.5 |
|---|
comment:9 Changed 10 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Heights are the same now (in claro theme) for 1.5.
comment:10 Changed 10 years ago by
| Milestone: | 1.5 → 1.6 |
|---|
1.5 is released, moving remaining tickets to 1.6
screenshot of height-mismatched buttons