Opened 12 years ago

Closed 9 years ago

Last modified 9 years ago

#6151 closed defect (fixed)

Button: unequal height of buttons

Reported by: bill Owned by: nonken
Priority: high Milestone: 1.6
Component: Dijit - LnF Version: 1.0
Keywords: Cc:
Blocked By: Blocking:

Description (last modified by bill)

See themeTester.html.

Even if I change the test to use the same icon for all the buttons, the DropDownButton and !Button are taller than the ComboButton on IE. It's a slight difference, maybe 3px:

screenshot of height-mismatched buttons

(Note that the plus icon and note icon seem to be a different size... that's just a test file problem but please fix that too... however the main point of this ticket is that even when the icon is the same, the button heights are different.)

Attachments (1)

buttons.gif (3.5 KB) - added by bill 12 years ago.
screenshot of height-mismatched buttons

Download all attachments as: .zip

Change History (11)

Changed 12 years ago by bill

Attachment: buttons.gif added

screenshot of height-mismatched buttons

comment:1 Changed 12 years ago by bill

Description: modified (diff)

comment:2 Changed 12 years ago by bill

Description: modified (diff)

comment:3 Changed 11 years ago by bill

Component: DijitDijit - LnF

comment:4 Changed 11 years ago by bill

Description: modified (diff)

As per email thread, this seems to be because ComboButton doesn't contain a <button> node. To quote Doug:

I think ComboButton should have a table with a button node on the left and a non-button on the right. I couldn't get this to size correctly but that was a long time ago. Maybe a fresh try by Nikolai will be successful.

comment:5 Changed 11 years ago by nonken

Status: newassigned

comment:6 Changed 11 years ago by bill

Milestone: 1.31.4

comment:7 Changed 10 years ago by Douglas Hays

patch in #6150 fixes the ComboButton? height - not the margin problem and the ToggleButton? is still hs a different height.

comment:8 Changed 10 years ago by bill

Milestone: 1.41.5

comment:9 Changed 9 years ago by bill

Resolution: fixed
Status: assignedclosed

Heights are the same now (in claro theme) for 1.5.

comment:10 Changed 9 years ago by bill

Milestone: 1.51.6

1.5 is released, moving remaining tickets to 1.6

Note: See TracTickets for help on using tickets.