Opened 12 years ago

Closed 11 years ago

Last modified 11 years ago

#6147 closed defect (fixed)

Spinner: border flashes while scrolling through values

Reported by: bill Owned by: bill
Priority: high Milestone: 1.3
Component: Dijit - LnF Version: 1.0
Keywords: Cc:
Blocked By: Blocking:

Description (last modified by nonken)

See i18n demo. Every time you press up/down arrow key, the border on the spinner changes color while the key is depressed.

Happens on tundra and maybe other themes.

Reproduced on FF2 and IE6.

See also #6177.

Change History (10)

comment:1 Changed 12 years ago by Douglas Hays

This is actually working as designed. When you press the arrow keys, the buttons are supposed to act like you pressed them. With the buttons pressed, the box is "active" and thus the themes change to active mode. Maybe the buttons can be styled w/o styling the input box.

comment:2 Changed 12 years ago by bill

Description: modified (diff)

Just to clarify, the buttons are supposed to change color as they are being pressed (and that is working correctly) but the problem is that the input box border (Spinner.domNode) is coming along for the ride.

comment:3 Changed 12 years ago by bill

Owner: changed from Douglas Hays to nonken

comment:4 Changed 12 years ago by bill

Description: modified (diff)

comment:5 Changed 12 years ago by bill

Component: DijitDijit - LnF

comment:6 Changed 11 years ago by nonken

Description: modified (diff)
Milestone: 1.21.3
Status: newassigned

Needs further clarification. Also should go along with further theme generalisation for hover and active states.

comment:7 Changed 11 years ago by bill

Owner: changed from nonken to bill
Status: assignednew

This is [more than] just a CSS problem. There are issues with _FormWidget._setStateClass().

comment:8 Changed 11 years ago by bill

(In [15989]) First in series of checkins to fix border colors when pressing spinner up/down buttons. Currently, when pressing spinner buttons the CSS class on the spinner's *domNode* changes from dijitSpinnerFocused to dijitSpinnerDownArrowActive.

This is working as design, but perhaps the design is overkill; probably pressing the button should only change the class of the button node itself.

Refs #6147

comment:9 Changed 11 years ago by bill

Resolution: fixed
Status: newclosed

(In [15990]) Hovering over a spinner up/down arrow button shouldn't change the border color. Border color is controlled by rules in Common.css; rules in Button.css shouldn't interfere. Fixes #6147.

comment:10 Changed 11 years ago by bill

I should clarify my comment that:

This is [more than] just a CSS problem. There are issues with _FormWidget._setStateClass().

As stated above, when pressing spinner buttons the CSS class on the spinner's *domNode* changes from dijitSpinnerFocused to dijitSpinnerDownArrowActive.

There are two questionable things here:

  • why is the dijitSpinnerDownArrowActive class erasing the dijitSpinnerFocused class? I guess it's to avoid a proliferation of too many classes.
  • as stated above we could KISS by making the button press just change the class of the button itself. The current code sets the class on the domNode so that we can change the look of the whole widget while the button is being pressed. However, that doesn't seem very useful. I think Noir wanted this?
Note: See TracTickets for help on using tickets.