Opened 11 years ago

Closed 11 years ago

#6129 closed defect (fixed)

Editor: onChange is broken

Reported by: Douglas Hays Owned by: haysmark
Priority: high Milestone: 1.1
Component: Editor Version: 1.1b1
Keywords: Cc:
Blocked By: Blocking:

Description

Put the attached testcase next to dojo/ and dijit/ and run it. Click in the editor box and type, then click the input box. onChange should fire.
Using FF2, onChange does not fire after the first change.
Using IE, onChange fires during widget init which is wrong, then does not fire when the above test is run, but does fire when the focus is returned to the editor which is again wrong = 3 mistakes.
For IE, this is a regression since this was working in 1.0.x.

Attachments (3)

editor.html (1.4 KB) - added by Douglas Hays 11 years ago.
testcase, save next to dojo/ and dijit/
6129_102.patch (428 bytes) - added by haysmark 11 years ago.
Fixes #6129 in 1.0x branch. Set height of Editor's iframe html and body to 100% so focus manager registers the click.
6129_11.patch (1.9 KB) - added by haysmark 11 years ago.
Fixes #6129 in 1.1 branch. Set height of Editor's iframe html and body to 100% so focus manager registers the click. Set savedContent after initialization to prevent firing onChange when no change was made.

Download all attachments as: .zip

Change History (7)

Changed 11 years ago by Douglas Hays

Attachment: editor.html added

testcase, save next to dojo/ and dijit/

comment:1 Changed 11 years ago by Douglas Hays

Owner: changed from liucougar to haysmark
severity: majorcritical

comment:2 Changed 11 years ago by Douglas Hays

Needed on 1.0.x as well.

Changed 11 years ago by haysmark

Attachment: 6129_102.patch added

Fixes #6129 in 1.0x branch. Set height of Editor's iframe html and body to 100% so focus manager registers the click.

comment:3 Changed 11 years ago by Douglas Hays

The IE problem remans - the patches fix the Firefox problem.

Changed 11 years ago by haysmark

Attachment: 6129_11.patch added

Fixes #6129 in 1.1 branch. Set height of Editor's iframe html and body to 100% so focus manager registers the click. Set savedContent after initialization to prevent firing onChange when no change was made.

comment:4 Changed 11 years ago by Douglas Hays

Resolution: fixed
Status: newclosed

(In [13054]) Fixes #6129. Proxy commit for haysmark. Set height of Editor's iframe html and body to 100% so focus manager registers the click. Set savedContent after initialization to prevent firing onChange when no change was made. Change blur() to not hide the entire browser window but just remove focus from the editor.

Note: See TracTickets for help on using tickets.