Opened 12 years ago
Closed 12 years ago
#6129 closed defect (fixed)
Editor: onChange is broken
| Reported by: | Douglas Hays | Owned by: | haysmark |
|---|---|---|---|
| Priority: | high | Milestone: | 1.1 |
| Component: | Editor | Version: | 1.1b1 |
| Keywords: | Cc: | ||
| Blocked By: | Blocking: |
Description
Put the attached testcase next to dojo/ and dijit/ and run it.
Click in the editor box and type, then click the input box. onChange should fire.
Using FF2, onChange does not fire after the first change.
Using IE, onChange fires during widget init which is wrong, then does not fire when the above test is run, but does fire when the focus is returned to the editor which is again wrong = 3 mistakes.
For IE, this is a regression since this was working in 1.0.x.
Attachments (3)
Change History (7)
Changed 12 years ago by
| Attachment: | editor.html added |
|---|
comment:1 Changed 12 years ago by
| Owner: | changed from liucougar to haysmark |
|---|---|
| severity: | major → critical |
Changed 12 years ago by
| Attachment: | 6129_102.patch added |
|---|
Fixes #6129 in 1.0x branch. Set height of Editor's iframe html and body to 100% so focus manager registers the click.
Changed 12 years ago by
| Attachment: | 6129_11.patch added |
|---|
Fixes #6129 in 1.1 branch. Set height of Editor's iframe html and body to 100% so focus manager registers the click. Set savedContent after initialization to prevent firing onChange when no change was made.
comment:4 Changed 12 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
(In [13054]) Fixes #6129. Proxy commit for haysmark. Set height of Editor's iframe html and body to 100% so focus manager registers the click. Set savedContent after initialization to prevent firing onChange when no change was made. Change blur() to not hide the entire browser window but just remove focus from the editor.
testcase, save next to dojo/ and dijit/