dijit.tree.TreeStoreModel.mayHaveChildren incorrectly implemented

[guest]

The current implementation uses: return dojo.some(this.childrenAttr, function(attr){

return this.store.hasAttribute(item, attr);

}, this);

but as this.childrenAttr is a string, every character is treated as an element of an array. For a childrenAttr like 'children', the function that will be executed is

return this.store.hasAttribute(item, 'c') return this.store.hasAttribute(item, 'h') return this.store.hasAttribute(item, 'i') ...

The correct, expected behaviour, occurs when wrapping the value this.childrenAttr in an Array, thus using the implementation:

return dojo.some([this.childrenAttr], function(attr){

return this.store.hasAttribute(item, attr);

}, this);

[bill]

No, it's an array, see the declaration:

	// childrenAttr: String
	//		one ore more attributes that holds children of a tree node
	childrenAttr: ["children"],

[bill]

PS: but I will change the variable name to be childrenAttrs so it's less confusing. Plus fix the comment to say String{].

[bill]

(In [12981]) Refs #6126, #6127: fix comment for childrenAttr to note that it's an array, plus change name to childrenAttrs to be less confusing. !strict

[bill]

(In [12982]) Refs #6126, #6127: change name to childrenAttrs to be less confusing (except for Tree widget itself, for back compat) !strict

[bill]

(In [12984]) Refs #6126, #6127: Fix bug in testcase; childrenAttrs is an array so needs to be passed in as such.