Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#6104 closed defect (fixed)

some dijit.css class names do not start with dijit

Reported by: Douglas Hays Owned by: Douglas Hays
Priority: high Milestone: 1.1
Component: Dijit Version: 1.0
Keywords: themes Cc: Adam Peller
Blocked By: Blocking:

Description (last modified by bill)

The following class names in dijit.css are inconsistently named and may more easily conflict with user class names if not renamed to dijitBlah
RuleContainer?
VerticalRuleContainer?
RuleMark?
HorizontalRuleMark?
RuleLabelContainer?
HorizontalRuleLabelContainer?
HorizontalRuleLabel?
VerticalRuleMark?
IEFixedToolbar

As per our meeting on 3/10/2008, also

  • shorten Horizontal and Vertical to H and V
  • put H and V at end of word for grouping (ie, RuleLabelContainerH) rather than as prefix
  • change .dijitSplitterHorizontal to .dijitSplitterH (and same for V), see BorderContainer.js

Change History (5)

comment:1 Changed 12 years ago by bill

Description: modified (diff)

comment:2 Changed 12 years ago by Douglas Hays

dijitProgressBarVertical -> dijitProgressBarV dijitVerticalSliderBlahBlah -> dijitSliderBlahBlahV dijitHorizontalSliderBlahBlah -> dijitSliderBlahBlahH

comment:3 Changed 12 years ago by Douglas Hays

Class names changed: old => new

IEFixedToolbar dijitIEFixedToolbar
dijitProgressBarVertical dijitProgressBarV
dijitProgressBarHorizontal dijitProgressBarH
RuleContainer dijitRuleContainer
HorizontalRuleContainer dijitRuleContainerH
VerticalRuleContainer dijitRuleContainerV
RuleLabel dijitRuleLabel
RuleLabelContainer dijitRuleLabelContainer
HorizontalRuleLabelContainer dijitRuleLabelContainerH
VerticalRuleLabelContainer dijitRuleLabelContainerV
HorizontalRuleLabel dijitRuleLabelH
VerticalRuleLabel dijitRuleLabelV
RuleMark dijitRuleMark
HorizontalRuleMark dijitRuleMarkH
VerticalRuleMark dijitRuleMarkV
dijitHorizontalSliderBar dijitSliderBarH
dijitVerticalSliderBar dijitSliderBarV
dijitVerticalSliderBottomBumper dijitSliderBottomBumper
dijitHorizontalSliderBumper dijitSliderBumperH
dijitVerticalSliderBumper dijitSliderBumperV
dijitVerticalSliderButtonContainer dijitSliderButtonContainerV
dijitHorizontalSliderButtonContainer dijitSliderButtonContainerH
dijitHorizontalSliderDecoration dijitSliderDecorationH
dijitVerticalSliderDecoration dijitSliderDecorationV
dijitHorizontalSliderImageHandle dijitSliderImageHandleH
dijitVerticalSliderImageHandle dijitSliderImageHandleV
dijitHorizontalSliderLeftBumper dijitSliderLeftBumper
dijitHorizontalSliderMoveable dijitSliderMoveableH
dijitVerticalSliderMoveable dijitSliderMoveableV
dijitHorizontalSliderProgressBar dijitSliderProgressBarH
dijitVerticalSliderProgressBar dijitSliderProgressBarV
dijitHorizontalSliderRemainingBar dijitSliderRemainingBarH
dijitVerticalSliderRemainingBar dijitSliderRemainingBarV
dijitHorizontalSliderRightBumper dijitSliderRightBumper
dijitVerticalSliderTopBumper dijitSliderTopBumper
dijitSplitterHorizontal dijitSplitterH
dijitSplitterVertical dijitSplitterV
dijitHorizontalSliderDecrementIcon dijitSliderDecrementIconH
dijitHorizontalSliderIncrementIcon dijitSliderIncrementIconH
dijitVerticalSliderIncrementIcon dijitSliderIncrementIconV
dijitVerticalSliderDecrementIcon dijitSliderDecrementIconV

comment:4 Changed 12 years ago by Douglas Hays

Resolution: fixed
Status: newclosed

Fixed by revision [13000].

comment:5 Changed 12 years ago by Douglas Hays

(In [13044]) References #6104 !strict. Fixed constructed class name on L364 of BorderContainer?.js.

Note: See TracTickets for help on using tickets.