Opened 12 years ago

Closed 12 years ago

#6100 closed defect (fixed)

[CLA][PATCH]buildUtil.guardProvideRegExp bug if dojo.provide is followed by an other statement containing ") or ') on the same line

Reported by: guest Owned by: James Burke
Priority: high Milestone: 1.1
Component: BuildSystem Version: 1.0
Keywords: Cc:
Blocked By: Blocking:

Description

If dojo.provide is followed by an other statement containing ") or ') on the same line buildUtil.guardProvideRegExp match second statement too.

Example: buildUtil.guardProvideRegExp applied on code like this dojo.provide("acme.nls.acme-all_en");dojo.provide("dojo.nls.colors");
match
acme.nls.acme-all_en");dojo.provide("dojo.nls.colors

After patch match
acme.nls.acme-all_en

Attachments (1)

provideRegexpFix.patch (527 bytes) - added by guest 12 years ago.
Provided by Alessandro Ferrari

Download all attachments as: .zip

Change History (3)

Changed 12 years ago by guest

Attachment: provideRegexpFix.patch added

Provided by Alessandro Ferrari

comment:1 Changed 12 years ago by Adam Peller

Milestone: 1.1

comment:2 Changed 12 years ago by James Burke

Resolution: fixed
Status: newclosed

(In [12957]) Fixes #6100: bad regexp for the code guards. Thanks for the patch. !strict for redeclaration warnings.

Note: See TracTickets for help on using tickets.