Opened 11 years ago

Closed 11 years ago

#6099 closed defect (fixed)

ExpandoPane isHorizontal logic reversed?

Reported by: Sam Foster Owned by: dante
Priority: high Milestone: 1.1
Component: DojoX Widgets Version: 1.1b1
Keywords: Cc: dante
Blocked By: Blocking:

Description

ExpandoPanes? have a _isHorizontal property that's used to determine which axis the pane should expand/collapse along etc. isHorizontal is set thusly:

this._isHorizontal = !/top|bottom/.test(this.region);

to me this is reversed. Top and bottom region panes /are/ horizontal - their splitters will be horizontal. Expansion is along the 'y' or vertical axis - but the property name is ambiguous at best if that's the intention.

Proposal: reverse the logic:

this._isHorizontal = /top|bottom/.test(this.region);

.. or, rename the property to _isHorizontalAxis or something.

Its private so while this might screw some people who'd extended from ExpandoPane?, its not strictly a public api change? (also ExpandoPane? is marked as experimental still)

Change History (2)

comment:1 Changed 11 years ago by dante

Milestone: 1.21.1
Status: newassigned

comment:2 Changed 11 years ago by dante

Resolution: fixed
Status: assignedclosed

(In [12933]) fixes #6099 - logic private change of the meaning of _isHorizontal (the pane extends horizontally, whereas it was "the direction of the splitter movement" before)

Note: See TracTickets for help on using tickets.