#6054 closed enhancement (fixed)
ComboBox.js hard coded classes
Reported by: | dante | Owned by: | bill |
---|---|---|---|
Priority: | high | Milestone: | 1.6 |
Component: | Dijit - Form | Version: | 1.0 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description (last modified by )
Trying to subclass ComboBox became difficult when trying to connect to the popup, which uses the class dijit.form._ComboBoxMenu ...
suggest using a private _popupClass (as _popupWidget is in use) and using dojo.getObject to allow uses to plugin more easily.
Change History (8)
comment:1 Changed 14 years ago by
Description: | modified (diff) |
---|
comment:2 Changed 14 years ago by
Description: | modified (diff) |
---|---|
Milestone: | 1.2 → 1.4 |
comment:3 Changed 14 years ago by
Milestone: | 1.4 → 1.5 |
---|
bumping 1.4 tickets to 1.5, and most 1.3 tickets to 1.4
comment:4 Changed 14 years ago by
Milestone: | 1.5 → future |
---|
so this actually falls second to a larger plan I want to implement:
- enforce a rule like this everywhere. "no hard coded classes"
- use a cache of getObject lookups to only lookup once (parser has instanceClasses[i].cls already
comment:5 Changed 13 years ago by
Milestone: | future → 2.0 |
---|---|
Owner: | dante deleted |
Type: | task → enhancement |
so I'm going to move this to the 2.0/ambigious future milestone for lack of a better place to put them. In Dojo 2.0, we should normalize passing an object/function reference or string (eg: dojo.fx.easing.backOut) and Dijit should have some kind of getObject() cache (like dojo.parser does). This generalization covers all "hard-coded-classes" tickets. We should be able to pass a string (dojo.getObject) without taking ANY performance hit, a direct object (the fast path), or have sane defaults.
comment:6 Changed 12 years ago by
Milestone: | 2.0 → 1.6 |
---|---|
Owner: | set to bill |
Status: | new → assigned |
comment:7 Changed 12 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
comment:8 Changed 11 years ago by
Component: | Dijit → Dijit - Form |
---|
might drop back to 1.3 if these kinds of changes are on the 1.3 radar.