Opened 12 years ago

Closed 9 years ago

Last modified 9 years ago

#6054 closed enhancement (fixed)

ComboBox.js hard coded classes

Reported by: dante Owned by: bill
Priority: high Milestone: 1.6
Component: Dijit - Form Version: 1.0
Keywords: Cc:
Blocked By: Blocking:

Description (last modified by dante)

Trying to subclass ComboBox became difficult when trying to connect to the popup, which uses the class dijit.form._ComboBoxMenu ...

suggest using a private _popupClass (as _popupWidget is in use) and using dojo.getObject to allow uses to plugin more easily.

Change History (8)

comment:1 Changed 12 years ago by dante

Description: modified (diff)

comment:2 Changed 11 years ago by dante

Description: modified (diff)
Milestone: 1.21.4

might drop back to 1.3 if these kinds of changes are on the 1.3 radar.

comment:3 Changed 11 years ago by bill

Milestone: 1.41.5

bumping 1.4 tickets to 1.5, and most 1.3 tickets to 1.4

comment:4 Changed 11 years ago by dante

Milestone: 1.5future

so this actually falls second to a larger plan I want to implement:

  • enforce a rule like this everywhere. "no hard coded classes"
  • use a cache of getObject lookups to only lookup once (parser has instanceClasses[i].cls already

comment:5 Changed 11 years ago by dante

Milestone: future2.0
Owner: dante deleted
Type: taskenhancement

so I'm going to move this to the 2.0/ambigious future milestone for lack of a better place to put them. In Dojo 2.0, we should normalize passing an object/function reference or string (eg: dojo.fx.easing.backOut) and Dijit should have some kind of getObject() cache (like dojo.parser does). This generalization covers all "hard-coded-classes" tickets. We should be able to pass a string (dojo.getObject) without taking ANY performance hit, a direct object (the fast path), or have sane defaults.

comment:6 Changed 9 years ago by bill

Milestone: 2.01.6
Owner: set to bill
Status: newassigned

comment:7 Changed 9 years ago by bill

Resolution: fixed
Status: assignedclosed

(In [22674]) Ability to specify separate class for ComboBox drop down menu. Fixes #6054 !strict.

comment:8 Changed 9 years ago by bill

Component: DijitDijit - Form
Note: See TracTickets for help on using tickets.