Opened 11 years ago

Closed 11 years ago

#6047 closed defect (fixed)

[patch][cla]When editing in the grid using the defualt Dijit Text box, the focus jumps randomly around the page

Reported by: guest Owned by: benschell
Priority: high Milestone: 1.1.1
Component: DojoX Grid Version: 1.0
Keywords: Text Grid Focus Cc: rob_safe1@…
Blocked By: Blocking:

Description (last modified by benschell)

This error only occurs in IE 6.0 and IE 7.0 This error does not occur in FF2.

This error can be easily reproduced using the nightly test files for the grid

http://archive.dojotoolkit.org/nightly/dojotoolkit/dojox/grid/tests/test_edit_dijit.html

1) Double click on the first row in column 'Message' 2) Type some text 3) Move focus to another cell 4) Double click on the original cell and type some more text 5) The letters you now type appear in the wrong place (basically where the last focus point was)

Note that when using the option

editor: dojox.grid.editors.Input

instead of

editor: dojox.grid.editors.Dijit

and the error does not occur

I have also attached a simple, self-contained HTML example to recreated the error

Attachments (2)

Ticket 6047 - DojoXGridError.htm (1.6 KB) - added by guest 11 years ago.
6047.patch (1.2 KB) - added by benschell 11 years ago.

Download all attachments as: .zip

Change History (12)

Changed 11 years ago by guest

comment:1 Changed 11 years ago by Adam Peller

Owner: changed from sorvell to benschell

comment:2 Changed 11 years ago by Adam Peller

Milestone: 1.1

comment:3 Changed 11 years ago by benschell

Can you give me a little more information? I can't seem to reproduce this error.

The steps I've taken are:
1) Goto nightly page: http://archive.dojotoolkit.org/nightly/dojotoolkit/dojox/grid/tests/test_edit_dijit.html[[BR]] 2) Double click on row 1 in the message column. The Editor comes up.
3) Type something into the Editor
4) Click on the priority column in the first row (I've also tried rows other than the one first). The ComboBox? editor comes up.
5) Double-click on the message column in row 1 again. The Editor comes up.
6) Type something.

In doing the above, the typed text goes into the Editor in the message column as expected.

I also attempted playing with the provided test page. I opened the editor on the Read/Write? column, then tried changing the focus by clicking on any of the other 3 cells, then double-clicked on the same cell I originally opened to edit. Each time, typing would always result in the text going into the correct cell.

Any hints to reproduce?

comment:4 Changed 11 years ago by benschell

Status: newassigned

Actually....

I missed that most important first line of the description: 'This error only occurs in IE 6.0 and IE 7.0 This error does not occur in FF2.'. Please disregard the previous comment, and many apologies.

I am seeing the issue, but it's a little less complicated than the description implies. In fact, in IE, if you double click on a cell where the Editor widget will be used and start typing, the text will be displayed in an odd/unexpected location. It appears that when the Editor is lazy-loaded onto the page, the focus never gets put on the Editor's textarea.

I'll take a look.

comment:5 Changed 11 years ago by bill

Milestone: 1.11.2

Move all milestone 1.1 tickets to 1.2, except for reopened tickets and tickets opened after 1.1RC1 was released.

comment:6 Changed 11 years ago by benschell

Description: modified (diff)

This ticket is actually a pretty substantial bug. The indicated test page does not work correctly as of 1.1.

Attached patch fixes the existing buggy behavior ("'undefined' is null or not an object" in the error console) as well this bug, moving the cursor into the correct node to edit the content.

comment:7 Changed 11 years ago by Adam Peller

Milestone: 1.21.1.1
Summary: When editing in the grid using the defualt Dijit Text box, the focus jumps randomly around the page[patch][cla]When editing in the grid using the defualt Dijit Text box, the focus jumps randomly around the page

Changed 11 years ago by benschell

Attachment: 6047.patch added

comment:8 Changed 11 years ago by Adam Peller

Priority: normalhigh
severity: normalmajor

comment:9 Changed 11 years ago by Bryan Forbes

(In [13584]) refs #6047 !strict

  • Applied patch from Ben Schell to fix dijit editors in IE6 and IE7.

comment:10 Changed 11 years ago by Bryan Forbes

Resolution: fixed
Status: assignedclosed

(In [13585]) fixes #6047 !strict

  • Applied patch from Ben Schell (CLA) that fixes dijit editors in IE6 and IE7.
Note: See TracTickets for help on using tickets.