Opened 13 years ago

Closed 13 years ago

#6040 closed defect (fixed)

[patch] [cla] Rating widget spacing fix

Reported by: wolfram Owned by: dante
Priority: high Milestone: 1.1
Component: DojoX Widgets Version: 1.0
Keywords: Cc:
Blocked By: Blocking:

Description


Attachments (4)

patch6040.diff​ (3.8 KB) - added by wolfram 13 years ago.
new_images.tgz​ (2.7 KB) - added by wolfram 13 years ago.
The new images needed for the patch file
patch6040.2.diff​ (5.7 KB) - added by wolfram 13 years ago.
The latest patch, tested in IE6+7, FF2+3 (on linux, win, mac), Safari
new_images.2.tgz​ (2.7 KB) - added by wolfram 13 years ago.

Download all attachments as: .zip

Change History (11)

comment:1 Changed 13 years ago by wolfram

Summary: Rating widget spacing fix → [patch] [cla] Rating widget spacing fix

comment:2 Changed 13 years ago by dylan

Milestone: → 1.1

Changed 13 years ago by wolfram

Attachment: patch6040.diff​ added

comment:3 Changed 13 years ago by dante

Milestone: 1.1 → 1.2

the patch doesn't exactly work, and this isn't going to land for 1.1 (and dojox stuff will hopefully soon be free of dojo-release binding soon)

comment:4 Changed 13 years ago by wolfram

I uploaded a new patch yesterday, and that doesnt work either? what is the problem now?

Changed 13 years ago by wolfram

Attachment: new_images.tgz​ added

The new images needed for the patch file

Changed 13 years ago by wolfram

Attachment: patch6040.2.diff​ added

The latest patch, tested in IE6+7, FF2+3 (on linux, win, mac), Safari

comment:5 Changed 13 years ago by wolfram

commiting the new images (from new_images.tgz) will also resolve #6089 all patches made in directory dojox, also the new_images.tgz the old pngs can be removed. thx

Changed 13 years ago by wolfram

Attachment: new_images.2.tgz​ added

comment:6 Changed 13 years ago by dante

Milestone: 1.2 → 1.1
Status: new → assigned

comment:7 Changed 13 years ago by dante

Resolution: → fixed
Status: assigned → closed

(In [12968]) fixes #6089 and fixes #6040 - both patches from wolfram [cla] - good stuff. thanks!

Note: See TracTickets for help on using tickets.