Opened 12 years ago

Closed 11 years ago

Last modified 8 years ago

#6034 closed defect (fixed)

Slider documentation says that pageIncrement keys off of the shift+arrows

Reported by: ptwobrussell Owned by: Becky Gibson
Priority: high Milestone: 1.2
Component: Dijit - Form Version: 1.0
Keywords: Cc: Joseph Scheuhammer
Blocked By: Blocking:

Description (last modified by davidb)

As I was unearthing the code for Slider again, I was initially confused by what the pageIncrement attribute was supposed to be since the comment didn't make any sense. The comment said that "pageIncrement" was how much to nudge the widget by using the shift+arrow keys. Well, the code shows that it's keying off of the page keys (which explains the name). I point this out because unless someone reads the code they may not make the connection.

It's a trivial fix but important if you want people to understand how to use this feature.

Attachments (1)

6034.diff (387 bytes) - added by davidb 11 years ago.
quick fix (during bug list triage with clown)

Download all attachments as: .zip

Change History (7)

comment:1 Changed 12 years ago by bill

Owner: set to Becky Gibson

Becky, which keys did you want it to be? both?

comment:2 Changed 12 years ago by Becky Gibson

On 2/21/08 I updated the slider doc to strike-through the shift+arrow info for the pageIncrement attribute and I added pageup/down. I also added an A11y section that describes using pageup/down for larger increments. Pageup/down is what is being used in the implementation. I'll modify the comment in the slider code as well. I do want it to be pageup/down rather than shift+arrow.

Changed 11 years ago by davidb

Attachment: 6034.diff added

quick fix (during bug list triage with clown)

comment:3 Changed 11 years ago by davidb

Description: modified (diff)
Keywords: clown added

Thanks ptwobrussell, would the attached patch suffice?

comment:4 Changed 11 years ago by davidb

Resolution: fixed
Status: newclosed

(In [13347]) Fixes #6034: trivial comment correction (paired fix w clown)

comment:5 Changed 11 years ago by davidb

Cc: Joseph Scheuhammer added
Keywords: clown removed

comment:6 Changed 8 years ago by bill

Component: DijitDijit - Form
Note: See TracTickets for help on using tickets.