Opened 11 years ago

Closed 11 years ago

#6030 closed defect (wontfix)

Overriding templatePath fails in build

Reported by: Adam Peller Owned by: bill
Priority: high Milestone: 1.2
Component: Dijit Version: 1.0
Keywords: Cc:
Blocked By: Blocking:

Description

see test_Calendar, the commented out instance of dijit._Calendar at the bottom where I attempted to override the template by defining templatePath in the markup. This appears to work, but fails in a build environment, where a templateString was generated which conflicts with templatePath.

Change History (6)

comment:1 Changed 11 years ago by Adam Peller

(In [12774]) Use declare to create custom calendar instead of templatePath in markup. Fixes #1287, Refs #6030

comment:2 Changed 11 years ago by bill

Resolution: wontfix
Status: newclosed

Right, this is just the way it works; if you override templatePath then you need to override templateString too (to set it to null). No intention to change that.

comment:3 Changed 11 years ago by Adam Peller

to be clear, we're saying this isn't supported in markup. there seems to be no way to set templatePath in markup with or without templateString

comment:4 Changed 11 years ago by guest

Resolution: wontfix
Status: closedreopened

Please fix the test page to reflect this ticket resolution (that you can’t actually override the templatePath from markup):

http://archive.dojotoolkit.org/nightly/dojotoolkit/dijit/tests/test_Calendar.html

In lieu of formal documentation on many of the dojo components, I have resorted to using the tests as examples for how to get things working. This test page has two issues that I have found so far:

One is that it still shows overriding the templatePath from markup (which, apparently, will never work, and I wasted at least two hours trying to figure out why before I found this ticket). I’ll admit that the example showing this method of overriding is commented out in the code, but since it was there I thought it meant that it was an appropriate way to override the templatePath.

The other issue is that the example of using the custom template is broken since it does not set the templateString to null in the declaration of BigCalendar?.

comment:5 Changed 11 years ago by bill

(In [14127]) Fix misleading example. Refs #6030.

comment:6 Changed 11 years ago by bill

Resolution: wontfix
Status: reopenedclosed

OK, I fixed the example, sorry that misled you.

Note: See TracTickets for help on using tickets.