Opened 6 years ago

Closed 2 weeks ago

#6029 closed enhancement (patchwelcome)

Font Name in Editor doesn't show state for Arial, others not on list

Reported by: peller Owned by: peller
Priority: low Milestone: future
Component: Editor Version: 1.0
Keywords: Cc:
Blocked by: Blocking:

Description

This appears to be a shortcoming of FilteredSelect. How do we get it to show values not on the list?

Attachments (1)

map.patch (7.6 KB) - added by bill 6 years ago.
mapping code for serif --> arial, etc plus an abbreviated test file with sample text in each font.

Download all attachments as: .zip

Change History (13)

comment:1 Changed 6 years ago by peller

As Bill points out, there are a large number of issues with editor fonts, portability across locales and operating systems, and even with importing content, but to list them here would likely confuse a number of bugs.

The bug is simply that selecting a range in IE results in a font of Arial which is not presently on the list. A kludge would be to add that one font to the list. A more general solution would be to allow for any selected font to be tolerated by the Font Name toolbar widget, even if it's not in its known list.

To reproduce, in IE:

load test_Editor.html
look for editor with font name dropdown
select a range and select a font.
click on something else
the selection comes back as arial and the filtered select shows a warning and an inconsistent state with the last font chosen

it may be more involved than this, as I haven't investigated fully. I wanted to jot something down so this wouldn't get lost.

comment:2 Changed 6 years ago by peller

  • Milestone changed from 1.2 to 1.1

comment:3 Changed 6 years ago by peller

  • Owner changed from liucougar to peller
  • Status changed from new to assigned

Changed 6 years ago by bill

mapping code for serif --> arial, etc plus an abbreviated test file with sample text in each font.

comment:4 Changed 6 years ago by peller

(In [12964]) Nedes more testing. Let's play with this set up. Allows custom fonts on djConfig to replace CSS "generics", and maps them back so IE is sane. Refs #6029 !strict

comment:5 Changed 6 years ago by peller

(In [12983]) A bit more hacking on fonts. Quote fonts with space on safari and process single quotes. Refs #6029

comment:6 Changed 6 years ago by bill

  • Priority changed from normal to high

comment:7 Changed 6 years ago by peller

(In [13060]) Add font examples in content, remove bogus fontName definition. Fixes #6179 Refs #6029

comment:8 Changed 6 years ago by peller

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [13061]) specify generics, custom list as options on FontChoice. Fixes #6029, #6035

comment:9 Changed 6 years ago by peller

  • Milestone changed from 1.1 to 1.2
  • Priority changed from high to normal
  • Resolution fixed deleted
  • Status changed from closed to reopened
  • Type changed from defect to enhancement

hmm... just realized there is another aspect to this. I think what I originally meant was the ability to have FilteringSelect pick up values on-the-fly, whether based on selection or by the user typing something into the field that isn't in the data store. The mapping we put in place only solves the problem wrt CSS generic fonts, but there are endless font choices out there. Think about this for 1.2+

comment:10 Changed 6 years ago by peller

  • Milestone changed from 1.2 to future

comment:11 Changed 16 months ago by bill

  • Priority changed from high to low

comment:12 Changed 2 weeks ago by bill

  • Resolution set to patchwelcome
  • Status changed from reopened to closed

Unlikely this will be fixed unless someone wants to supply a patch (including a test case).

Note: See TracTickets for help on using tickets.