Opened 14 years ago

Closed 12 years ago

Last modified 12 years ago

#599 closed task (fixed)

TimePicker: implement

Reported by: jan831@… Owned by: haysmark
Priority: high Milestone: 1.0
Component: Dijit Version: 0.3
Keywords: Cc:
Blocked By: Blocking:

Description

A more elaborate version of the time picker would be nice

features to have: custom format, showing hours also in 24h-format, a more graphical way of selecting a time, ...

IMHO this is a nice intuitive way of picking times and time intervals:

(warning java-applet!!) http://java.arcadevillage.com/applets/timepica.htm

Attachments (1)

599.patch (822 bytes) - added by haysmark 12 years ago.
Refs #599. Added a TimeTextBox?+TimePicker? to themeTester.

Download all attachments as: .zip

Change History (16)

comment:1 Changed 14 years ago by anonymous

Version: 0.20.4

comment:2 Changed 13 years ago by dylan

Milestone: 0.4
Owner: changed from anonymous to dylan
Status: newassigned

comment:3 Changed 13 years ago by dylan

Milestone: 0.40.5
Version: 0.40.3

comment:4 Changed 13 years ago by bill

Milestone: 0.91.0
Owner: changed from dylan to haysmark
Status: assignednew

This would be good for 1.0; Mark, do you want to try this (if there is time)?

comment:5 Changed 12 years ago by Adam Peller

Component: WidgetsDijit

comment:6 Changed 12 years ago by Adam Peller

Priority: lownormal
Summary: enhanced time pickernew time picker widget
Type: enhancementtask

See also #1874, #1872, #2477

comment:7 Changed 12 years ago by haysmark

Status: newassigned

comment:8 Changed 12 years ago by bill

(In [9697]) Added a graphical _TimePicker based on the Calendar API. Added TimeTextbox?, a slightly more general DateTextbox? with the _TimePicker as a popup widget. DateTextbox? extends TimeTextbox?, uses a Calendar instead of a _TimePicker. DateTextbox? uses the correct toISOString arguments to only submit the date. Fixes #3782. Refs #599.

Code from Mark Hays (IBM, CCLA on file)

comment:9 Changed 12 years ago by bill

Cool this looks good; a few things I noticed:

  • clickableIncrementHeight is a CSS property and should be specified in dijit.css (or maybe tundra.css), not via javascript
  • createOption also sets some other CSS properties that should be set in dijit.css (ie, you should set div.className but never div.style)
  • "calendar" should be renamed to "popup" or something more generic
  • this line seems strange and unnecessary, as lang is defined in _Widget.js:

lang:this.lang,

comment:10 Changed 12 years ago by Adam Peller

Looks great!

The TimePicker? does not seem to show the initial selection.

also, _TimePicker should probably live in the same package as _Calendar for symmetry. I chose not to put _Calendar in form because it in itself is not a form element. The "_" isn't really for private, it's just to mark the class as unsupported standalone for a11y reasons.

comment:11 Changed 12 years ago by bill

(In [9897]) Refactored inlined TimePicker? styles into dijitTimePicker classes. Added additional comments. Refs #599.

Patch from Mark Hays (IBM, CCLA on file)

comment:12 Changed 12 years ago by bill

Summary: new time picker widgetTimePicker: implement

This is essentially finished but needs some bug fixing to display the current time selected, and also tundra theme.

comment:13 Changed 12 years ago by haysmark

Tundra task assigned in #4133.

comment:14 Changed 12 years ago by haysmark

Resolution: fixed
Status: assignedclosed

It's implemented. Other tickets open for other issues.

Changed 12 years ago by haysmark

Attachment: 599.patch added

Refs #599. Added a TimeTextBox?+TimePicker? to themeTester.

comment:15 Changed 12 years ago by Adam Peller

(In [10802]) Add TimeTextBox? to themeTester, but fix localization issues first. You can't fix on en-us without loading it, and I think setting an example of fixed locales is going to mislead users. Refs #599.

Note: See TracTickets for help on using tickets.