Opened 12 years ago

Closed 11 years ago

#5982 closed enhancement (wontfix)

[cla][patch][test] missing message is not correct on validation text box

Reported by: nathan Owned by: Douglas Hays
Priority: high Milestone: 1.2
Component: Dijit Version: 1.0
Keywords: Cc:
Blocked By: Blocking:

Description (last modified by bill)

When a ValidationTextBox? is marked as "required", and it is not filled out, the tooltip error is the invalid message. Instead, the error should be the missing message (which is in the nls file already).

This patch includes an update to the dijit/tests/form/test_validation.html test case as well as a fix.

Attachments (1)

ValidationTextBox_Message.patch (2.1 KB) - added by guest 12 years ago.
Fix to validation text box error message by Nathan Toone

Download all attachments as: .zip

Change History (8)

Changed 12 years ago by guest

Fix to validation text box error message by Nathan Toone

comment:1 Changed 11 years ago by bill

Milestone: 1.1
Owner: set to Douglas Hays

Related to #5958. Doug, can you check this in unless it makes things noiser? I want to avoid popping up messages prematurely, like complaining that a field is missing when the user hasn't had a chance to type anything yet.

comment:2 Changed 11 years ago by Douglas Hays

The missing message support was removed via #2743 since it was shown only after focusing a required textbox twice and not typing anything or typing and then deleting characters. It seems a little strange to flicker different messages as they type and backspace and then retype but I'm OK with this change if its seemed important. It will impact existing customers who use customized messages. Now when they move to 1.1, they wil have a new noncustomized message showing and it might upset them.

comment:3 Changed 11 years ago by guest

That's fine - if the decision to remove it has been made, you can feel free to close this.

I would suggest, however, removing the "missingMessage" entry from nls/validate.js

comment:4 Changed 11 years ago by Douglas Hays

Milestone: 1.11.2
Type: defectenhancement

Need to think about this more post 1.1. The missingMessage was left as an aid to anyone wanting to create a subclass since it was already translated.

comment:5 Changed 11 years ago by nathan

Cc: nathan added; nathan@… removed

comment:6 Changed 11 years ago by nathan

Cc: nathan removed
Reporter: changed from guest to nathan

comment:7 Changed 11 years ago by bill

Description: modified (diff)
Resolution: wontfix
Status: newclosed

Right, I just wanted to have one message that says something like "Enter an age between 0 and 100", which can be used in either the blank case or the invalid case.

The currently displayed invalideMessage is incorrect (in the case where the field is blank), but no need need to fix it: both missingMessage and invalidMessage should be removed from the message file; I'll add that as a comment to #5958, which is related.

Note: See TracTickets for help on using tickets.