Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#5969 closed defect (fixed)

Editor should not use setDisabled

Reported by: Douglas Hays Owned by: liucougar
Priority: high Milestone: 1.2
Component: Editor Version: 1.1b1
Keywords: Cc: alex, bill
Blocked By: Blocking:

Description

Editor uses setDisabled. I think this should be setAttribute('disabled',boolean) for consistency with the form widgets.

Change History (5)

comment:1 Changed 11 years ago by dylan

Milestone: 1.1 → 1.2

Not sure this is valid, as editor needs to implement its own setDisabled method. That said, for consistency, it would be easy to implement a shim for this.

comment:2 Changed 11 years ago by liucougar

we need to deprecate setDisabled, right?

comment:3 Changed 11 years ago by bill

Right, for consistency deprecate setDisabled() and implement setAttribute('disabled',boolean)

comment:4 Changed 11 years ago by liucougar

Resolution: → fixed
Status: new → closed

(In [13903]) fixes #5969: deprecate setDisabled in favor of setAttribute

comment:5 Changed 11 years ago by liucougar

(In [13907]) refs #5969: properly setup firefox editor when it is enabled (in none-iframe mode)

Note: See TracTickets for help on using tickets.