Opened 12 years ago

Closed 12 years ago

#5956 closed defect (fixed)

dojox.validate.isValidCreditCard loops forever

Reported by: guest Owned by: Adam Peller
Priority: high Milestone: 1.1
Component: Dojox Version: 1.0
Keywords: Cc: bill@…, tk, dante
Blocked By: Blocking:

Description

Try this in Firebug:

dojo.require("dojox.validate");
dojo.require("dojox.validate.creditCard");
dojox.validate.isValidCreditCard("4111 1111 1111 1111", "vi");

The result is that dojox.validate.isValidLuhn() appears to go into an infinite loop. However note that running isValidLuhn() works as expected (returns true almost immediately):

dojox.validate.isValidLuhn("4111 1111 1111 1111");

The problem appears to occur with both 1.0.2 and in the svn head.

We discovered this because a client was complaining that their customers' browsers were hanging when entering an order. Not a good way to run an ecom business. :-/

-- Bill / bitranch

Change History (3)

comment:1 Changed 12 years ago by Adam Peller

Milestone: 1.1

comment:2 Changed 12 years ago by Adam Peller

Cc: tk dante added

comment:3 Changed 12 years ago by Adam Peller

Resolution: fixed
Status: newclosed

(In [12675]) don't do a dojo.indexOf on a hash. Fixes #5956

Note: See TracTickets for help on using tickets.