Opened 11 years ago

Closed 3 years ago

#5954 closed enhancement (fixed)

[patch] [cla] animation API wonkyness

Reported by: alex Owned by: dylan
Priority: high Milestone: 1.11
Component: fx Version: 1.0
Keywords: Cc:
Blocked By: Blocking:

Description (last modified by Dustin Machi)

we need some argument type detection in the animation APIs. For instance, the following should work:

dojo.fadeOut("idOfNode").play();

dojo.fx.chain(
  dojo.fadeOut("id1"),
  dojo.fadeIn("id2")
).play()

Attachments (1)

fx_js.patch (1.3 KB) - added by nic 7 years ago.
possible simple patch (tested changing the arguments in dojo/tests/test_fx.html)

Download all attachments as: .zip

Change History (12)

comment:1 Changed 11 years ago by Dustin Machi

Description: modified (diff)
Type: defectenhancement

comment:2 Changed 11 years ago by bill

Milestone: 1.2future

defer dormant enhancements to "future" (they don't look like they're getting fixed soon so might as well mark as such)

comment:3 Changed 8 years ago by Chris Mitchell

Owner: changed from alex to dylan

please review/triage

comment:4 Changed 8 years ago by dylan

Component: Corefx
Milestone: future1.8
Owner: changed from dylan to none

comment:5 Changed 8 years ago by bill

Owner: none deleted

Changed 7 years ago by nic

Attachment: fx_js.patch added

possible simple patch (tested changing the arguments in dojo/tests/test_fx.html)

comment:6 Changed 7 years ago by Colin Snover

Milestone: 1.82.0

1.8 is frozen. Move all enhancements to next release. If you need an exemption from the freeze for this ticket, contact me immediately.

comment:7 Changed 7 years ago by bill

Summary: animation API wonkyness[patch] [cla] animation API wonkyness

comment:8 Changed 6 years ago by dylan

Milestone: 2.01.9
Owner: set to Bryan Forbes
Status: newassigned

Patch looks reasonable to me.

Bryan, please consider this for 1.9

comment:9 Changed 6 years ago by bill

Milestone: 1.92.0

Since we released the beta for 1.9, presumably this enhancement should be bumped to 2.0.

comment:10 Changed 3 years ago by dylan

Milestone: 2.01.11
Owner: changed from Bryan Forbes to dylan

Will review this for 1.11.

comment:11 Changed 3 years ago by dylan

Resolution: fixed
Status: assignedclosed

Fix landed after 8 years (and 4 since nic's original patch)... https://github.com/dojo/dojo/commit/ab283730805469166b8f2f22738199c0e69915e5

Note: See TracTickets for help on using tickets.