Opened 11 years ago

Closed 11 years ago

Last modified 8 years ago

#5953 closed defect (fixed)

[cla][patch] dijit.form.MultiSelect should reference containerNode

Reported by: nathan Owned by: bill
Priority: high Milestone: 1.1
Component: Dijit - Form Version: 1.0
Keywords: Cc:
Blocked By: Blocking:

Description

It is currently referencing domNode in quite a few places where it shouldn't. A patch follows.

Attachments (1)

multiselect.patch (1.3 KB) - added by guest 11 years ago.
Patch to use containerNode instead of domNode

Download all attachments as: .zip

Change History (6)

Changed 11 years ago by guest

Attachment: multiselect.patch added

Patch to use containerNode instead of domNode

comment:1 Changed 11 years ago by bill

Cc: nathan@… removed
Milestone: 1.1
Owner: set to bill
Reporter: changed from guest to nathan@…
Status: newassigned

Hi Nathan. In this widget containerNode and domNode are the same thing... I guess you are thinking about subclassing it, or changing the template?

comment:2 Changed 11 years ago by guest

Yes - sorry, I forgot to mention that in the description of the bug (I mentioned it on IRC, but forgot to put it in here). The patch is needed in order to subclass or template the widget differently. Without it, it's almost easier to just override all the functions in MultiSelect?.

comment:3 Changed 11 years ago by bill

Resolution: fixed
Status: assignedclosed

(In [12631]) Fixes #5953: dijit.form.MultiSelect? should reference containerNode rather than domNode

comment:4 Changed 11 years ago by nathan

Reporter: changed from nathan@… to nathan

comment:5 Changed 8 years ago by bill

Component: DijitDijit - Form
Note: See TracTickets for help on using tickets.