Opened 12 years ago

Closed 11 years ago

#5949 closed defect (fixed)

[patch][cla] dojox.dtl._HtmlTemplated

Reported by: guest Owned by: Neil Roberts
Priority: high Milestone: 1.1
Component: Dojox Version: 1.0
Keywords: Cc:
Blocked By: Blocking:

Description

Solve 2 problems:

var old = ddcd.widgetsInTemplate;
is set after
ddcd.widgetsInTemplate = this.widgetsInTemplate;
so
ddcd.widgetsInTemplate = old;
has no effect.
Patch change this order.

render method called from setTimeout receive a numeric argument that break its behavior.
Patch ensure no argument is passed.

Attachments (1)

dtlFix.patch​ (877 bytes) - added by guest 12 years ago.
Provided by Alessandro Ferrari

Download all attachments as: .zip

Change History (4)

Changed 12 years ago by guest

Attachment: dtlFix.patch​ added

Provided by Alessandro Ferrari

comment:1 Changed 12 years ago by Adam Peller

Owner: changed from Adam Peller to Neil Roberts

comment:2 Changed 12 years ago by dylan

Milestone: → 1.1

comment:3 Changed 11 years ago by Neil Roberts

Resolution: → fixed
Status: new → closed

(In [12688]) Fixes #5949.

  • Properly save previous widgetsInTemplate state
  • Prevent argument from being passed to render during timeout
  • Thanks for Alessandro for noticing
  • !strict
Note: See TracTickets for help on using tickets.