Opened 12 years ago

Closed 12 years ago

#5946 closed defect (fixed)

Code error(s) in dojo/tests $ut8 should be $utf8

Reported by: guest Owned by: alex
Priority: high Milestone: 1.1
Component: TestFramework Version: 1.0
Keywords: Cc:
Blocked By: Blocking:

Description

Howdy,

I 'installed' dojo 1.0.2 (thank you for copy and paste) and ran the tests from dojo/tests/runTests.html as instructed.

Investigating one set of errors that kept popping up, I noticed two errors that when I 'fixed' them, the errors went away and runTests ran smoothly. The offending files have not been changed (according to trac) for 10 months or more, so I am uncertain if my fix was appropriate, but if not the variables are undefined:

1) In dojo/tests/resources/JSON.php, line 197: change "return $ut8;" to "return $utf8;"

http://trac.dojotoolkit.org/browser/dojo/trunk/tests/resources/JSON.php

2) In dojox/grid/tests/support/json.php line 212: change "return $ut8;" to "return $utf8;"

http://trac.dojotoolkit.org/browser/dojox/trunk/grid/tests/support/json.php

I am not certain why my runTests.html even got to the errors as the comments claim we should "never get here", but my system did and it crashed the runTests.html.

I am running on FF2 or O9 on FedoraCore6 and serving from same box with PHP5, HTTPD2, etc.

Regards, guest.

Change History (2)

comment:1 Changed 12 years ago by dylan

Milestone: 1.1

Looks like an easy fix.

comment:2 Changed 12 years ago by Adam Peller

Resolution: fixed
Status: newclosed

(In [12642]) Typo. Fixes #5946

Note: See TracTickets for help on using tickets.