Opened 14 years ago

Last modified 14 years ago

#5941 closed enhancement

to many hard-coded classes in dijit — at Initial Version

Reported by: dante Owned by:
Priority: high Milestone: 1.2
Component: Dijit Version: 1.0
Keywords: Cc:
Blocked By: Blocking:

Description

often, you see something like

this.something = new dijit.layout._TabButton()

i propose we make it a "rule" to disallow this. (unless dojo.getObject is expensive and i'm missing something?)

it would make subclassing / extending / modifying worlds easier for our users.

wildbill mentioned a few points: some places a factory makes more sense, some places a var like:

buttonClass:"dijit.layout._TabButton",
something:function(){
  var o = dojo.getObject(this.buttonClass);
  new o();
}

makes more sense.

marking 1.2, but would like to see some simple changes happen before 1.1 ? :)

Change History (0)

Note: See TracTickets for help on using tickets.