Opened 11 years ago

Closed 11 years ago

#5941 closed enhancement (fixed)

hard-coded classes in TabContainer.js

Reported by: dante Owned by: dante
Priority: high Milestone: 1.2
Component: Dijit Version: 1.0
Keywords: Cc:
Blocked By: Blocking:

Description (last modified by dante)

often, you see something like 

this.something = new dijit.layout._TabButton()

i propose we make it a "rule" to disallow this. (unless dojo.getObject is expensive and i'm missing something?)

it would make subclassing / extending / modifying worlds easier for our users.

wildbill mentioned a few points: some places a factory makes more sense, some places a var like: 

buttonClass:"dijit.layout._TabButton",
something:function(){
  var o = dojo.getObject(this.buttonClass);
  new o();
}

makes more sense.

marking 1.2, but would like to see some simple changes happen before 1.1 ? :)

Attachments (1)

tabContainer.patch​ (3.0 KB) - added by dante 11 years ago.

Download all attachments as: .zip

Change History (5)

comment:1 Changed 11 years ago by bill

Owner: set to dante

Like I said on IRC, please break this out into individual tickets per widget. All I know this applies to is TabContainer?, and maybe ComboBox?. Tree is already documented in #5719.

comment:2 Changed 11 years ago by dante

Summary: to many hard-coded classes in dijit → hard-coded classes in TabContainer.js

Changed 11 years ago by dante

Attachment: tabContainer.patch​ added

comment:3 Changed 11 years ago by Adam Peller

(In [12795]) Dante's patch to remove hard-coded class reference. Left property as 'private' for now. Refs #5941

comment:4 Changed 11 years ago by dante

Description: modified (diff)
Resolution: → fixed
Status: new → closed

everything in tabcontainer can be extended. marking as fixed. thanks peller.

Note: See TracTickets for help on using tickets.