Changes between Initial Version and Version 2 of Ticket #5922


Ignore:
Timestamp:
Feb 21, 2008, 3:35:36 AM (12 years ago)
Author:
Adam Peller
Comment:

Thanks for the patch. Some questions:

  • What's "dojo.loaderParseError" and where is it used?
  • The patch appears to make a global out of the function openWin() that was otherwise hidden in a closure. Was there a reason for this?
  • For the cookie, I'd suggest that rather than duplicating the dojo.cookie code, we only take what we need and inline it. In this case, document.cookie= seems sufficient to set... Are the props even needed? getting a cookie is a regexp (see new dojo.cookie code)

If you can get me a minimal patch for the IE crash, I'll get it in for 1.1, and we can do the rest for 1.2.

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #5922

    • Property Owner changed from anonymous to Adam Peller
    • Property Priority changed from normal to high
    • Property Milestone changed from to 1.1
  • Ticket #5922 – Description

    initial v2  
    22HTML needs a height in Safari
    33
    4 Fixed IE, ref 4644 - IE Crashes when clearing console: [[BR]]
     4Fixed #4644 - IE Crashes when clearing console: [[BR]]
    55IE didn't crash until you hovered over the main page, so it may have been ellusive. Who would have guessed - setting the consoleBody.innerHTML="" fubar'd IE. destroying elements instead.
    66