Opened 12 years ago

Closed 12 years ago

Last modified 8 years ago

#5917 closed defect (fixed)

ComboBox ESC key / revert problem

Reported by: Douglas Hays Owned by: haysmark
Priority: high Milestone: 1.1
Component: Dijit - Form Version: 1.1b1
Keywords: Cc:
Blocked By: Blocking:

Description

Run dijit/tests/for/test_ComboBox.html
Focus on the first box (Iowa) and type something.
Press the Esc key.
The field blanks out and fires onChange.
The field should have reverted to Iowa and no onChange fired.

Attachments (1)

5917.patch (3.0 KB) - added by haysmark 12 years ago.
Fixes #5917. Fix escape key handling in ComboBox?.

Download all attachments as: .zip

Change History (4)

comment:1 Changed 12 years ago by haysmark

This is a regression in [10872]. I documented the regression in my review of the patch; see #4633. The issue was fixed for FilteringSelect? but not ComboBox?.

Changed 12 years ago by haysmark

Attachment: 5917.patch added

Fixes #5917. Fix escape key handling in ComboBox?.

comment:2 Changed 12 years ago by Douglas Hays

Resolution: fixed
Status: newclosed

(In [12597]) Fixes #5917. Changed ComboBoxMixin? to use the _FormWidget:_onKeyPressed to manage undo.

comment:3 Changed 8 years ago by bill

Component: DijitDijit - Form
Note: See TracTickets for help on using tickets.