Opened 12 years ago

Closed 11 years ago

#5901 closed defect (fixed)

IE6 Syntax Exception in _loadUri

Reported by: guest Owned by: Adam Peller
Priority: high Milestone: 1.1
Component: Core Version: 1.0
Keywords: Cc:
Blocked By: Blocking:

Description

G'day,

Ive got the 1.0.2 release version of Dojo I'm integrating in my web application, i am currently only using it for pre-filled FilterSelects?. It was working in fine but wouldn't load in IE6, I would get this error:

Could not load 'dijit.form.FilteringSelect?'; last tried '../dijit/form/FilteringSelect'

After some debuging i found dojo._loadUri was throwing a syntax exception complaining about a missing ';'

I tracked it down to line 375 of dojo.js.uncompress.js in the _loadUri function:

var value = deval?(contents+" @ sourceURL="+uri);

adding a space between the comment & the @ symbol fixed my problem ala:

var value = deval?(contents+" @ sourceURL="+uri);

Looks like the line added to the code is causing the exception when its eval'ed

Regards, Phill

PS: upgrading from old and buggy version of 0.4, 1.x is looking very nice, good work :D

Change History (7)

comment:1 Changed 12 years ago by Adam Peller

Owner: changed from anonymous to Adam Peller

comment:2 Changed 12 years ago by guest

Original submitter here. The tests for filter select work fine for me off the same server/browser

It maybe be something with my app but im not 100% sure what

comment:3 Changed 12 years ago by Adam Peller

Resolution: worksforme
Status: newclosed

if you're using an old firebug (1.0) or venkman, it typically will report all errors in code that went through the Dojo loader at the point of their eval, rather than the actual line of source. Given that this line is basically doing that eval in debug mode, perhaps that's all you're seeing? It wouldn't make any sense that inserting a space would make it go away, but perhaps like you say it wasn't really reproducible?

http://dojotoolkit.org/support/faq/why-does-my-mozilla-debugger-venkman-firebug-aptana-report-all-errors-loader-js

Please reopen if you can pinpoint this. You may also want to try Firebug 1.1.

comment:4 Changed 11 years ago by dante

Resolution: worksforme
Status: closedreopened

see also #6096 (which is why i reopen)

comment:5 Changed 11 years ago by Adam Peller

Milestone: 1.1
Priority: normalhigh
Status: reopenednew

Cougar helped me figure this out. This syntax seems to conflict with IE's conditional syntax. We'll just omit it on all browsers, except FF. I guess it was a bad choice for a lead-in (my bad)

comment:6 Changed 11 years ago by Adam Peller

Status: newassigned

comment:7 Changed 11 years ago by Adam Peller

Resolution: fixed
Status: assignedclosed

(In [12942]) Append @ to buffer for debugging only for Gecko-based browsers. Fixes #5901

Note: See TracTickets for help on using tickets.