Opened 13 years ago
Closed 13 years ago
#5899 closed defect (fixed)
[cla][patch][unit test]dojo DeferredList return broken (plus fix for typo)
Reported by: | tvachon | Owned by: | Dustin Machi |
---|---|---|---|
Priority: | high | Milestone: | 1.1 |
Component: | General | Version: | 1.0 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description
Currently, the following code:
var d1 = new dojo.Deferred(); var d2 = new dojo.Deferred(); var dl = new dojo.DeferredList([d1, d2]); dl.addCallback(function(res){ console.log(res); }); d1.callback("foo"); d2.callback("bar");
prints a list like [undefined, [true, "foo"], [true, "bar]] to the console, when it should be printing true, "foo"], [true, "bar"?
Attached patch fixes this and adds some basic regression tests.
Attachments (1)
Change History (5)
comment:1 Changed 13 years ago by
Milestone: | → 1.1 |
---|---|
Owner: | changed from anonymous to Dustin Machi |
Priority: | normal → high |
Summary: | dojo DeferredList return broken (plus fix for typo) → [patch][cla?][unit test]dojo DeferredList return broken (plus fix for typo) |
Changed 13 years ago by
Attachment: | dojoDeferredList.patch added |
---|
comment:2 Changed 13 years ago by
Summary: | [patch][cla?][unit test]dojo DeferredList return broken (plus fix for typo) → [patch][unit test]dojo DeferredList return broken (plus fix for typo) |
---|
CLA submitted 2/19/2008.
comment:3 Changed 13 years ago by
Summary: | [patch][unit test]dojo DeferredList return broken (plus fix for typo) → [cla][patch][unit test]dojo DeferredList return broken (plus fix for typo) |
---|
comment:4 Changed 13 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
Note: See
TracTickets for help on using
tickets.
Patch to fix problem + tests. (Updates to remove variable and not fix typo, since it's already been fixed in changeset 12508)